Fix PHPStan issues for /src/Twig/TwigExtension.php

All bundled in one commit to not flood the history, all of these should
be trivial on itself but help PHPStan to detect more issues.

Also fixed an issue for the DOMjudge service as we return the outcome
from there.

Author: vmcj

phpstan-baseline.neon

@@ -565,11 +565,6 @@ parameters:
 			count: 1
 			path: webapp/src/Service/DOMJudgeService.php
 
-		-
-			message: "#^Method App\\\\Service\\\\DOMJudgeService\\:\\:getAssetFiles\\(\\) return type has no value type specified in iterable type array\\.$#"
-			count: 1
-			path: webapp/src/Service/DOMJudgeService.php
-
 		-
 			message: "#^Method App\\\\Service\\\\DOMJudgeService\\:\\:getContestStats\\(\\) return type has no value type specified in iterable type array\\.$#"
 			count: 1
@@ -999,33 +994,3 @@ parameters:
 			message: "#^Method App\\\\Service\\\\SubmissionService\\:\\:getSubmissionList\\(\\) return type has no value type specified in iterable type array\\.$#"
 			count: 1
 			path: webapp/src/Service/SubmissionService.php
-
-		-
-			message: "#^Method App\\\\Twig\\\\TwigExtension\\:\\:customAssetFiles\\(\\) return type has no value type specified in iterable type array\\.$#"
-			count: 1
-			path: webapp/src/Twig/TwigExtension.php
-
-		-
-			message: "#^Method App\\\\Twig\\\\TwigExtension\\:\\:displayTestcaseResults\\(\\) has parameter \\$testcases with no value type specified in iterable type array\\.$#"
-			count: 1
-			path: webapp/src/Twig/TwigExtension.php
-
-		-
-			message: "#^Method App\\\\Twig\\\\TwigExtension\\:\\:getCommonPrefix\\(\\) has parameter \\$strings with no value type specified in iterable type array\\.$#"
-			count: 1
-			path: webapp/src/Twig/TwigExtension.php
-
-		-
-			message: "#^Method App\\\\Twig\\\\TwigExtension\\:\\:numTableActions\\(\\) has parameter \\$tableData with no value type specified in iterable type array\\.$#"
-			count: 1
-			path: webapp/src/Twig/TwigExtension.php
-
-		-
-			message: "#^Method App\\\\Twig\\\\TwigExtension\\:\\:printHosts\\(\\) has parameter \\$hostnames with no value type specified in iterable type array\\.$#"
-			count: 1
-			path: webapp/src/Twig/TwigExtension.php
-
-		-
-			message: "#^Method App\\\\Twig\\\\TwigExtension\\:\\:runDiff\\(\\) has parameter \\$runOutput with no value type specified in iterable type array\\.$#"
-			count: 1
-			path: webapp/src/Twig/TwigExtension.php

webapp/src/Service/DOMJudgeService.php

@@ -1338,6 +1338,8 @@ public function apiRelativeUrl(string $route, array $params = []): string
 
     /**
      * Get asset files in the given directory with the given extension
+     *
+     * @return string[]
      */
     public function getAssetFiles(string $path): array
     {

webapp/src/Twig/TwigExtension.php

@@ -426,9 +426,11 @@ public function testcaseResults(Submission $submission, ?bool $showExternal = fa
     }
 
     // TODO: this function shares a lot with the above one, unify them?
+    /**
+     * @param Testcase[] $testcases
+     */
     public function displayTestcaseResults(array $testcases, bool $submissionDone, bool $isExternal = false): string
     {
-        /** @var Testcase[] $testcases */
         $results = '';
         $lastTypeSample = true;
         foreach ($testcases as $testcase) {
@@ -627,6 +629,8 @@ public function printHost(?string $hostname, bool $full = false): string
 
     /**
      * Extract the longest common prefix of all the provided strings.
+     *
+     * @param string[] $strings
      */
     private function getCommonPrefix(array $strings): string
     {
@@ -650,6 +654,8 @@ private function getCommonPrefix(array $strings): string
 
     /**
      * Formats a list of given hostnames, extracting a common prefix and suffix.
+     *
+     * @param string[] $hostnames
      */
     public function printHosts(array $hostnames): string
     {
@@ -754,6 +760,9 @@ public function interactiveLog(string $log, bool $forTeam = false): string
         return $header . $body . "</table>" . $truncation;
     }
 
+    /**
+     * @param array{output_run: string, output_reference: string} $runOutput
+     */
     public function runDiff(array $runOutput): string
     {
         // TODO: can be improved using diffposition.txt
@@ -896,6 +905,9 @@ public function printContestStart(Contest $contest): string
         return $res;
     }
 
+    /**
+     * @return string[]
+     */
     public function customAssetFiles(string $type): array
     {
         if (in_array($type, ['css', 'js'])) {
@@ -1166,6 +1178,13 @@ public function entityIdBadge(BaseApiEntity $entity, string $idPrefix = ''): str
         return $this->twig->render('jury/entity_id_badge.html.twig', $data);
     }
 
+    /**
+     * @param array<array{data: array<string, array{value: string, sortvalue?: string, title?: string, cssclass?: string}>,
+     *                    link: string,
+     *                    actions?: array{icon: string, title: string, link: string, ajaxModal?: bool},
+     *                    cssclass?: string
+     *        }> $tableData
+     */
     protected function numTableActions(array $tableData): int
     {
         $maxNumActions = 0;