Properly implement the troolean

In the past we had a fake troolean:
null (pick from somewhere else)
true (do lazy)
false (do every testcase)

Now we have actually a fake 4-way boolean:
1-3 lazy, ondemand & full
0 default

Author: vmcj

webapp/migrations/Version20240319140330.php

@@ -0,0 +1,33 @@
+<?php
+
+declare(strict_types=1);
+
+namespace DoctrineMigrations;
+
+use Doctrine\DBAL\Schema\Schema;
+use Doctrine\Migrations\AbstractMigration;
+
+final class Version20240319140330 extends AbstractMigration
+{
+    public function getDescription(): string
+    {
+        return 'Convert default `null` to `0` when the global value should be picked.';
+    }
+
+    public function up(Schema $schema): void
+    {
+	$this->addSql('UPDATE contestproblem SET lazy_eval_results = 0 WHERE lazy_eval_results IS NULL');
+        $this->addSql('ALTER TABLE contestproblem CHANGE lazy_eval_results lazy_eval_results INT UNSIGNED NOT NULL COMMENT \'Whether to do lazy evaluation for this problem; if set this overrides the global configuration setting\'');
+    }
+
+    public function down(Schema $schema): void
+    {
+        $this->addSql('ALTER TABLE contestproblem CHANGE lazy_eval_results lazy_eval_results INT UNSIGNED DEFAULT NULL COMMENT \'Whether to do lazy evaluation for this problem; if set this overrides the global configuration setting\'');
+	$this->addSql('UPDATE contestproblem SET lazy_eval_results = NULL WHERE lazy_eval_results = 0');
+    }
+
+    public function isTransactional(): bool
+    {
+        return false;
+    }
+}

webapp/src/Controller/API/JudgehostController.php

@@ -994,7 +994,7 @@ private function addSingleJudgingRun(
             // Lookup global lazy evaluation of results setting and possible problem specific override.
             $lazyEval    = $this->config->get('lazy_eval_results');
             $problemLazy = $judging->getSubmission()->getContestProblem()->getLazyEvalResults();
-            if (isset($problemLazy)) {
+            if ($problemLazy !== DOMJudgeService::EVAL_DEFAULT) {
                 $lazyEval = $problemLazy;
             }
 

webapp/src/Controller/API/ProblemController.php

@@ -332,8 +332,8 @@ public function linkProblemAction(
 
         $contest = $this->em->getRepository(Contest::class)->find($this->getContestId($request));
 
-        $lazyEvalResults = null;
-        if ($contestProblemPut->lazyEvalResults !== null) {
+        $lazyEvalResults = 0;
+        if ($contestProblemPut->lazyEvalResults !== DOMJudgeService::LAZY_DEFAULT) {
             $lazyEvalResults = (int)$contestProblemPut->lazyEvalResults;
         }
 

webapp/src/DataTransferObject/ContestProblemPut.php

@@ -16,7 +16,7 @@ public function __construct(
         public readonly ?string $rgb,
         #[OA\Property(description: 'The number of points for the problem to add. Defaults to 1')]
         public readonly int $points = 1,
-        #[OA\Property(description: 'Whether to use lazy evaluation for this problem. Defaults to the global setting', nullable: true)]
-        public readonly ?bool $lazyEvalResults = null,
+        #[OA\Property(description: 'Whether to use lazy evaluation for this problem. Defaults to the global setting')]
+        public readonly int $lazyEvalResults = 0,
     ) {}
 }

webapp/src/Entity/ContestProblem.php

@@ -71,11 +71,11 @@ class ContestProblem
     private ?string $color = null;
 
     #[ORM\Column(
-        nullable: true,
+        nullable: false,
         options: ['comment' => 'Whether to do lazy evaluation for this problem; if set this overrides the global configuration setting', 'unsigned' => true]
     )]
     #[Serializer\Exclude]
-    private ?int $lazyEvalResults = null;
+    private int $lazyEvalResults = 0;
 
     #[ORM\Id]
     #[ORM\ManyToOne(inversedBy: 'problems')]
@@ -193,13 +193,13 @@ public function getApiColor(): ?string
         return Utils::convertToColor($this->getColor());
     }
 
-    public function setLazyEvalResults(?int $lazyEvalResults): ContestProblem
+    public function setLazyEvalResults(int $lazyEvalResults): ContestProblem
     {
-        $this->lazyEvalResults = $lazyEvalResults === 0 ? null : $lazyEvalResults;
+        $this->lazyEvalResults = $lazyEvalResults;
         return $this;
     }
 
-    public function getLazyEvalResults(): ?int
+    public function getLazyEvalResults(): int
     {
         return $this->lazyEvalResults;
     }

webapp/src/Form/Type/ContestProblemType.php

@@ -58,7 +58,7 @@ public function buildForm(FormBuilderInterface $builder, array $options): void
         $builder->add('lazyEvalResults', ChoiceType::class, [
             'label' => 'Lazy eval',
             'choices' => [
-                'Default' => null,
+                'Default' => DJS::EVAL_DEFAULT,
                 'Yes' => DJS::EVAL_LAZY,
                 'No' => DJS::EVAL_FULL,
                 'On demand' => DJS::EVAL_DEMAND,

webapp/src/Service/DOMJudgeService.php

@@ -70,7 +70,7 @@ class DOMJudgeService
     final public const DATA_SOURCE_LOCAL = 0;
     final public const DATA_SOURCE_CONFIGURATION_EXTERNAL = 1;
     final public const DATA_SOURCE_CONFIGURATION_AND_LIVE_EXTERNAL = 2;
-    final public const EVAL_DEFAULT = null;
+    final public const EVAL_DEFAULT = 0;
     final public const EVAL_LAZY = 1;
     final public const EVAL_FULL = 2;
     final public const EVAL_DEMAND = 3;
@@ -1163,7 +1163,7 @@ public function maybeCreateJudgeTasks(Judging $judging, int $priority = JudgeTas
 
         $evalOnDemand = false;
         // We have 2 cases, the problem picks the global value or the value is set.
-        if (((int)$problem->getLazyEvalResults() === (int)DOMJudgeService::EVAL_DEFAULT && $this->config->get('lazy_eval_results') === static::EVAL_DEMAND)
+        if (($problem->getLazyEvalResults() === DOMJudgeService::EVAL_DEFAULT && $this->config->get('lazy_eval_results') === static::EVAL_DEMAND)
              || $problem->getLazyEvalResults() === DOMJudgeService::EVAL_DEMAND) {
             $evalOnDemand = true;
         }