Operator logging for database init SQL failures #3033
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If there is an error in the init SQL that runs as part of reconcileDatabaseInitSQL, then there is no way for the user to know what the error is. Adding this additional log statement will make it easier for users to know when init sql operations have succeeded and/or failed. It also brings this part of the code up to par with other similar operations in the codebase. Issue: CrunchyData#3029
|
Is there a maintainer who could review this PR? Thank you in advance. |
mariusstaicu
approved these changes
Sep 26, 2022
sanfoobar
approved these changes
Oct 6, 2022
benjaminjb
approved these changes
Oct 18, 2022
|
Thanks for the PR -- approved and merged! Hope that helps debug init sql issues. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If there is an error in the init SQL that runs as part of reconcileDatabaseInitSQL, then there is no way for the user to know what the error is. Adding this additional log statement will make it easier for users to know when init sql operations have succeeded and/or failed. It also brings this part of the code up to par with other similar operations in the codebase.
Checklist:
No. I tried to build the Docker image locally but ran into some issues, likely because my local env is a mac I'm guessing. Any tips here would be appreciated.
Type of Changes:
What is the current behavior (link to any open issues here)?
Issue: #3029
What is the new behavior (if this is a feature change)?
Additional Logging to help users diagnose failures
Other Information:
None