2531 HateoasSortHandlerMethodArgumentResolver should append * to the 'sort' parameter template variable

Julien Béti · reda-alaoui · commit 4100df6d9a44 · 2023-09-28T11:12:38.000+02:00
diff --git a/src/main/java/org/springframework/data/web/HateoasSortHandlerMethodArgumentResolver.java b/src/main/java/org/springframework/data/web/HateoasSortHandlerMethodArgumentResolver.java
@@ -57,9 +57,11 @@ public TemplateVariables getSortTemplateVariables(MethodParameter parameter, Uri
 			return TemplateVariables.NONE;
 		}
 
-		String description = String.format("pagination.%s.description", sortParameter);
+		String sortParameterExplode = sortParameter + '*';
+
+		String description = String.format("pagination.%s.description", sortParameterExplode);
 		TemplateVariable.VariableType type = append ? REQUEST_PARAM_CONTINUED : REQUEST_PARAM;
-		return new TemplateVariables(new TemplateVariable(sortParameter, type, description));
+		return new TemplateVariables(new TemplateVariable(sortParameterExplode, type, description));
 	}
 
 	@Override

Original file line number	Diff line number	Diff line change
`@@ -57,9 +57,11 @@ public TemplateVariables getSortTemplateVariables(MethodParameter parameter, Uri`
`57`	`57`	`return TemplateVariables.NONE;`
`58`	`58`	`}`
`59`	`59`
`60`		`- String description = String.format("pagination.%s.description", sortParameter);`
	`60`	`+ String sortParameterExplode = sortParameter + '*';`
	`61`	`+`
	`62`	`+ String description = String.format("pagination.%s.description", sortParameterExplode);`
`61`	`63`	`TemplateVariable.VariableType type = append ? REQUEST_PARAM_CONTINUED : REQUEST_PARAM;`
`62`		`- return new TemplateVariables(new TemplateVariable(sortParameter, type, description));`
	`64`	`+ return new TemplateVariables(new TemplateVariable(sortParameterExplode, type, description));`
`63`	`65`	`}`
`64`	`66`
`65`	`67`	`@Override`