Merge pull request #23 from Leanwit/master

Leanwit · web-flow · commit 35aacd510953 · 2020-11-27T09:45:20.000-03:00
[csharp] [booking] Remove unused imports and fix variable name in test
diff --git a/examples/csharp/csharp-booking-01_base/src/Booking/BookingId.cs b/examples/csharp/csharp-booking-01_base/src/Booking/BookingId.cs
@@ -1,6 +1,4 @@
-﻿using System;
-
-namespace CodelyTv.Booking
+﻿namespace CodelyTv.Booking
 {
     public sealed class BookingId
     {
diff --git a/examples/csharp/csharp-booking-01_base/src/Booking/CustomerName.cs b/examples/csharp/csharp-booking-01_base/src/Booking/CustomerName.cs
@@ -1,6 +1,4 @@
-﻿using System;
-
-namespace CodelyTv.Booking
+﻿namespace CodelyTv.Booking
 {
     public sealed class CustomerName
     {
diff --git a/examples/csharp/csharp-booking-01_base/test/Booking.Tests/BookingShould.cs b/examples/csharp/csharp-booking-01_base/test/Booking.Tests/BookingShould.cs
@@ -33,7 +33,7 @@ private void GetTheCorrectStatusWhenTheBookingHasNotStartedYet()
         [Fact]
         private void GetTheCorrectStatusWhenTheBookingIsCurrentlyActive()
         {
-            var dateBeforeBookingHasStarted = new DateTime(2020, 6, 29, 15, 0, 0);
+            var dateBetweenBooking = new DateTime(2020, 6, 29, 15, 0, 0);
 
             var bookingStartDate = new DateTime(2020, 6, 26, 19, 0, 0);
             var bookingEndDate = new DateTime(2020, 7, 14, 16, 0, 0);
@@ -52,13 +52,13 @@ private void GetTheCorrectStatusWhenTheBookingIsCurrentlyActive()
                 new TaxValue(0)
             );
 
-            Assert.Equal(BookingStatus.ACTIVE, booking.StatusFor(dateBeforeBookingHasStarted));
+            Assert.Equal(BookingStatus.ACTIVE, booking.StatusFor(dateBetweenBooking));
         }
 
         [Fact]
         private void GetTheCorrectStatusWhenTheBookingIsFinished()
         {
-            var dateBeforeBookingHasStarted = new DateTime(2020, 8, 30, 19, 0, 0);
+            var dateAfterBookingEnds = new DateTime(2020, 8, 30, 19, 0, 0);
 
             var bookingStartDate = new DateTime(2020, 6, 26, 19, 0, 0);
             var bookingEndDate = new DateTime(2020, 7, 14, 16, 0, 0);
@@ -77,7 +77,7 @@ private void GetTheCorrectStatusWhenTheBookingIsFinished()
                 new TaxValue(0)
             );
 
-            Assert.Equal(BookingStatus.FINISHED, booking.StatusFor(dateBeforeBookingHasStarted));
+            Assert.Equal(BookingStatus.FINISHED, booking.StatusFor(dateAfterBookingEnds));
         }
     }
 }
diff --git a/examples/csharp/csharp-booking-02_introduce_parameter_object/src/Booking/BookingId.cs b/examples/csharp/csharp-booking-02_introduce_parameter_object/src/Booking/BookingId.cs
@@ -1,6 +1,4 @@
-﻿using System;
-
-namespace CodelyTv.Booking
+﻿namespace CodelyTv.Booking
 {
     public sealed class BookingId
     {
diff --git a/examples/csharp/csharp-booking-02_introduce_parameter_object/src/Booking/CustomerName.cs b/examples/csharp/csharp-booking-02_introduce_parameter_object/src/Booking/CustomerName.cs
@@ -1,6 +1,4 @@
-﻿using System;
-
-namespace CodelyTv.Booking
+﻿namespace CodelyTv.Booking
 {
     public sealed class CustomerName
     {
diff --git a/examples/csharp/csharp-booking-02_introduce_parameter_object/src/Booking/DateRange.cs b/examples/csharp/csharp-booking-02_introduce_parameter_object/src/Booking/DateRange.cs
@@ -1,8 +1,4 @@
 ﻿using System;
-using System.Collections.Generic;
-using System.Linq;
-using System.Text;
-using System.Threading.Tasks;
 
 namespace CodelyTv.Booking
 {
diff --git a/examples/csharp/csharp-booking-02_introduce_parameter_object/src/Booking/Discount.cs b/examples/csharp/csharp-booking-02_introduce_parameter_object/src/Booking/Discount.cs
@@ -1,10 +1,4 @@
-﻿using System;
-using System.Collections.Generic;
-using System.Linq;
-using System.Text;
-using System.Threading.Tasks;
-
-namespace CodelyTv.Booking
+﻿namespace CodelyTv.Booking
 {
     public sealed class Discount
     {
diff --git a/examples/csharp/csharp-booking-02_introduce_parameter_object/test/Booking.Tests/BookingShould.cs b/examples/csharp/csharp-booking-02_introduce_parameter_object/test/Booking.Tests/BookingShould.cs
@@ -32,7 +32,7 @@ private void GetTheCorrectStatusWhenTheBookingHasNotStartedYet()
         [Fact]
         private void GetTheCorrectStatusWhenTheBookingIsCurrentlyActive()
         {
-            var dateBeforeBookingHasStarted = new DateTime(2020, 6, 29, 15, 0, 0);
+            var dateBetweenBooking = new DateTime(2020, 6, 29, 15, 0, 0);
 
             var bookingStartDate = new DateTime(2020, 6, 26, 19, 0, 0);
             var bookingEndDate = new DateTime(2020, 7, 14, 16, 0, 0);
@@ -50,13 +50,13 @@ private void GetTheCorrectStatusWhenTheBookingIsCurrentlyActive()
                 new Tax(TaxType.NONE, new TaxValue(0))
             );
 
-            Assert.Equal(BookingStatus.ACTIVE, booking.StatusFor(dateBeforeBookingHasStarted));
+            Assert.Equal(BookingStatus.ACTIVE, booking.StatusFor(dateBetweenBooking));
         }
 
         [Fact]
         private void GetTheCorrectStatusWhenTheBookingIsFinished()
         {
-            var dateBeforeBookingHasStarted = new DateTime(2020, 8, 30, 19, 0, 0);
+            var dateAfterBookingEnds = new DateTime(2020, 8, 30, 19, 0, 0);
 
             var bookingStartDate = new DateTime(2020, 6, 26, 19, 0, 0);
             var bookingEndDate = new DateTime(2020, 7, 14, 16, 0, 0);
@@ -74,7 +74,7 @@ private void GetTheCorrectStatusWhenTheBookingIsFinished()
                 new Tax(TaxType.NONE, new TaxValue(0))
             );
 
-            Assert.Equal(BookingStatus.FINISHED, booking.StatusFor(dateBeforeBookingHasStarted));
+            Assert.Equal(BookingStatus.FINISHED, booking.StatusFor(dateAfterBookingEnds));
         }
     }
 }
diff --git a/examples/csharp/csharp-booking-03_preserve_whole_object/src/Booking/BookingId.cs b/examples/csharp/csharp-booking-03_preserve_whole_object/src/Booking/BookingId.cs
@@ -1,6 +1,4 @@
-﻿using System;
-
-namespace CodelyTv.Booking
+﻿namespace CodelyTv.Booking
 {
     public sealed class BookingId
     {
diff --git a/examples/csharp/csharp-booking-03_preserve_whole_object/src/Booking/CustomerName.cs b/examples/csharp/csharp-booking-03_preserve_whole_object/src/Booking/CustomerName.cs
@@ -1,6 +1,4 @@
-﻿using System;
-
-namespace CodelyTv.Booking
+﻿namespace CodelyTv.Booking
 {
     public sealed class CustomerName
     {
diff --git a/examples/csharp/csharp-booking-03_preserve_whole_object/src/Booking/DateRange.cs b/examples/csharp/csharp-booking-03_preserve_whole_object/src/Booking/DateRange.cs
@@ -1,8 +1,4 @@
 ﻿using System;
-using System.Collections.Generic;
-using System.Linq;
-using System.Text;
-using System.Threading.Tasks;
 
 namespace CodelyTv.Booking
 {
diff --git a/examples/csharp/csharp-booking-03_preserve_whole_object/src/Booking/Discount.cs b/examples/csharp/csharp-booking-03_preserve_whole_object/src/Booking/Discount.cs
@@ -1,10 +1,4 @@
-﻿using System;
-using System.Collections.Generic;
-using System.Linq;
-using System.Text;
-using System.Threading.Tasks;
-
-namespace CodelyTv.Booking
+﻿namespace CodelyTv.Booking
 {
     public sealed class Discount
     {
diff --git a/examples/csharp/csharp-booking-03_preserve_whole_object/test/Booking.Tests/BookingShould.cs b/examples/csharp/csharp-booking-03_preserve_whole_object/test/Booking.Tests/BookingShould.cs
@@ -32,7 +32,7 @@ private void GetTheCorrectStatusWhenTheBookingHasNotStartedYet()
         [Fact]
         private void GetTheCorrectStatusWhenTheBookingIsCurrentlyActive()
         {
-            var dateBeforeBookingHasStarted = new DateTime(2020, 6, 29, 15, 0, 0);
+            var dateBetweenBooking = new DateTime(2020, 6, 29, 15, 0, 0);
 
             var bookingStartDate = new DateTime(2020, 6, 26, 19, 0, 0);
             var bookingEndDate = new DateTime(2020, 7, 14, 16, 0, 0);
@@ -50,13 +50,13 @@ private void GetTheCorrectStatusWhenTheBookingIsCurrentlyActive()
                 new Tax(TaxType.NONE, new TaxValue(0))
             );
 
-            Assert.Equal(BookingStatus.ACTIVE, booking.StatusFor(dateBeforeBookingHasStarted));
+            Assert.Equal(BookingStatus.ACTIVE, booking.StatusFor(dateBetweenBooking));
         }
 
         [Fact]
         private void GetTheCorrectStatusWhenTheBookingIsFinished()
         {
-            var dateBeforeBookingHasStarted = new DateTime(2020, 8, 30, 19, 0, 0);
+            var dateAfterBookingEnds = new DateTime(2020, 8, 30, 19, 0, 0);
 
             var bookingStartDate = new DateTime(2020, 6, 26, 19, 0, 0);
             var bookingEndDate = new DateTime(2020, 7, 14, 16, 0, 0);
@@ -74,7 +74,7 @@ private void GetTheCorrectStatusWhenTheBookingIsFinished()
                 new Tax(TaxType.NONE, new TaxValue(0))
             );
 
-            Assert.Equal(BookingStatus.FINISHED, booking.StatusFor(dateBeforeBookingHasStarted));
+            Assert.Equal(BookingStatus.FINISHED, booking.StatusFor(dateAfterBookingEnds));
         }
     }
 }
diff --git a/examples/csharp/csharp-booking-04_tell_dont_ask/src/Booking/BookingId.cs b/examples/csharp/csharp-booking-04_tell_dont_ask/src/Booking/BookingId.cs
@@ -1,12 +1,9 @@
-﻿using System;
-
-namespace CodelyTv.Booking
+﻿namespace CodelyTv.Booking
 {
     public sealed class BookingId
     {
         private readonly string value;
 
         public BookingId(string value) => this.value = value;
     }
-
 }
diff --git a/examples/csharp/csharp-booking-04_tell_dont_ask/src/Booking/CustomerName.cs b/examples/csharp/csharp-booking-04_tell_dont_ask/src/Booking/CustomerName.cs
@@ -1,12 +1,9 @@
-﻿using System;
-
-namespace CodelyTv.Booking
+﻿namespace CodelyTv.Booking
 {
     public sealed class CustomerName
     {
         private readonly string value;
 
         public CustomerName(string value) => this.value = value;
     }
-
 }
diff --git a/examples/csharp/csharp-booking-04_tell_dont_ask/src/Booking/Discount.cs b/examples/csharp/csharp-booking-04_tell_dont_ask/src/Booking/Discount.cs
@@ -1,10 +1,4 @@
-﻿using System;
-using System.Collections.Generic;
-using System.Linq;
-using System.Text;
-using System.Threading.Tasks;
-
-namespace CodelyTv.Booking
+﻿namespace CodelyTv.Booking
 {
     public sealed class Discount
     {
diff --git a/examples/csharp/csharp-booking-04_tell_dont_ask/test/Booking.Tests/BookingShould.cs b/examples/csharp/csharp-booking-04_tell_dont_ask/test/Booking.Tests/BookingShould.cs
@@ -32,7 +32,7 @@ private void GetTheCorrectStatusWhenTheBookingHasNotStartedYet()
         [Fact]
         private void GetTheCorrectStatusWhenTheBookingIsCurrentlyActive()
         {
-            var dateBeforeBookingHasStarted = new DateTime(2020, 6, 29, 15, 0, 0);
+            var dateBetweenBooking = new DateTime(2020, 6, 29, 15, 0, 0);
 
             var bookingStartDate = new DateTime(2020, 6, 26, 19, 0, 0);
             var bookingEndDate = new DateTime(2020, 7, 14, 16, 0, 0);
@@ -50,13 +50,13 @@ private void GetTheCorrectStatusWhenTheBookingIsCurrentlyActive()
                 new Tax(TaxType.NONE, new TaxValue(0))
             );
 
-            Assert.Equal(BookingStatus.ACTIVE, booking.StatusFor(dateBeforeBookingHasStarted));
+            Assert.Equal(BookingStatus.ACTIVE, booking.StatusFor(dateBetweenBooking));
         }
 
         [Fact]
         private void GetTheCorrectStatusWhenTheBookingIsFinished()
         {
-            var dateBeforeBookingHasStarted = new DateTime(2020, 8, 30, 19, 0, 0);
+            var dateAfterBookingEnds = new DateTime(2020, 8, 30, 19, 0, 0);
 
             var bookingStartDate = new DateTime(2020, 6, 26, 19, 0, 0);
             var bookingEndDate = new DateTime(2020, 7, 14, 16, 0, 0);
@@ -74,7 +74,7 @@ private void GetTheCorrectStatusWhenTheBookingIsFinished()
                 new Tax(TaxType.NONE, new TaxValue(0))
             );
 
-            Assert.Equal(BookingStatus.FINISHED, booking.StatusFor(dateBeforeBookingHasStarted));
+            Assert.Equal(BookingStatus.FINISHED, booking.StatusFor(dateAfterBookingEnds));
         }
     }
 }

Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,4 @@`
`1`		`-using System;`
`2`		`-`
`3`		`-namespace CodelyTv.Booking`
	`1`	`+namespace CodelyTv.Booking`
`4`	`2`	`{`
`5`	`3`	`public sealed class BookingId`
`6`	`4`	`{`
Original file line number	Diff line number	Diff line change
`@@ -33,7 +33,7 @@ private void GetTheCorrectStatusWhenTheBookingHasNotStartedYet()`
`33`	`33`	`[Fact]`
`34`	`34`	`private void GetTheCorrectStatusWhenTheBookingIsCurrentlyActive()`
`35`	`35`	`{`
`36`		`- var dateBeforeBookingHasStarted = new DateTime(2020, 6, 29, 15, 0, 0);`
	`36`	`+ var dateBetweenBooking = new DateTime(2020, 6, 29, 15, 0, 0);`
`37`	`37`
`38`	`38`	`var bookingStartDate = new DateTime(2020, 6, 26, 19, 0, 0);`
`39`	`39`	`var bookingEndDate = new DateTime(2020, 7, 14, 16, 0, 0);`
`@@ -52,13 +52,13 @@ private void GetTheCorrectStatusWhenTheBookingIsCurrentlyActive()`
`52`	`52`	`new TaxValue(0)`
`53`	`53`	`);`
`54`	`54`
`55`		`- Assert.Equal(BookingStatus.ACTIVE, booking.StatusFor(dateBeforeBookingHasStarted));`
	`55`	`+ Assert.Equal(BookingStatus.ACTIVE, booking.StatusFor(dateBetweenBooking));`
`56`	`56`	`}`
`57`	`57`
`58`	`58`	`[Fact]`
`59`	`59`	`private void GetTheCorrectStatusWhenTheBookingIsFinished()`
`60`	`60`	`{`
`61`		`- var dateBeforeBookingHasStarted = new DateTime(2020, 8, 30, 19, 0, 0);`
	`61`	`+ var dateAfterBookingEnds = new DateTime(2020, 8, 30, 19, 0, 0);`
`62`	`62`
`63`	`63`	`var bookingStartDate = new DateTime(2020, 6, 26, 19, 0, 0);`
`64`	`64`	`var bookingEndDate = new DateTime(2020, 7, 14, 16, 0, 0);`
`@@ -77,7 +77,7 @@ private void GetTheCorrectStatusWhenTheBookingIsFinished()`
`77`	`77`	`new TaxValue(0)`
`78`	`78`	`);`
`79`	`79`
`80`		`- Assert.Equal(BookingStatus.FINISHED, booking.StatusFor(dateBeforeBookingHasStarted));`
	`80`	`+ Assert.Equal(BookingStatus.FINISHED, booking.StatusFor(dateAfterBookingEnds));`
`81`	`81`	`}`
`82`	`82`	`}`
`83`	`83`	`}`
Original file line number	Diff line number	Diff line change
`@@ -1,8 +1,4 @@`
`1`	`1`	`using System;`
`2`		`-using System.Collections.Generic;`
`3`		`-using System.Linq;`
`4`		`-using System.Text;`
`5`		`-using System.Threading.Tasks;`
`6`	`2`
`7`	`3`	`namespace CodelyTv.Booking`
`8`	`4`	`{`
Original file line number	Diff line number	Diff line change
`@@ -1,10 +1,4 @@`
`1`		`-using System;`
`2`		`-using System.Collections.Generic;`
`3`		`-using System.Linq;`
`4`		`-using System.Text;`
`5`		`-using System.Threading.Tasks;`
`6`		`-`
`7`		`-namespace CodelyTv.Booking`
	`1`	`+namespace CodelyTv.Booking`
`8`	`2`	`{`
`9`	`3`	`public sealed class Discount`
`10`	`4`	`{`
Original file line number	Diff line number	Diff line change
`@@ -32,7 +32,7 @@ private void GetTheCorrectStatusWhenTheBookingHasNotStartedYet()`
`32`	`32`	`[Fact]`
`33`	`33`	`private void GetTheCorrectStatusWhenTheBookingIsCurrentlyActive()`
`34`	`34`	`{`
`35`		`- var dateBeforeBookingHasStarted = new DateTime(2020, 6, 29, 15, 0, 0);`
	`35`	`+ var dateBetweenBooking = new DateTime(2020, 6, 29, 15, 0, 0);`
`36`	`36`
`37`	`37`	`var bookingStartDate = new DateTime(2020, 6, 26, 19, 0, 0);`
`38`	`38`	`var bookingEndDate = new DateTime(2020, 7, 14, 16, 0, 0);`
`@@ -50,13 +50,13 @@ private void GetTheCorrectStatusWhenTheBookingIsCurrentlyActive()`
`50`	`50`	`new Tax(TaxType.NONE, new TaxValue(0))`
`51`	`51`	`);`
`52`	`52`
`53`		`- Assert.Equal(BookingStatus.ACTIVE, booking.StatusFor(dateBeforeBookingHasStarted));`
	`53`	`+ Assert.Equal(BookingStatus.ACTIVE, booking.StatusFor(dateBetweenBooking));`
`54`	`54`	`}`
`55`	`55`
`56`	`56`	`[Fact]`
`57`	`57`	`private void GetTheCorrectStatusWhenTheBookingIsFinished()`
`58`	`58`	`{`
`59`		`- var dateBeforeBookingHasStarted = new DateTime(2020, 8, 30, 19, 0, 0);`
	`59`	`+ var dateAfterBookingEnds = new DateTime(2020, 8, 30, 19, 0, 0);`
`60`	`60`
`61`	`61`	`var bookingStartDate = new DateTime(2020, 6, 26, 19, 0, 0);`
`62`	`62`	`var bookingEndDate = new DateTime(2020, 7, 14, 16, 0, 0);`
`@@ -74,7 +74,7 @@ private void GetTheCorrectStatusWhenTheBookingIsFinished()`
`74`	`74`	`new Tax(TaxType.NONE, new TaxValue(0))`
`75`	`75`	`);`
`76`	`76`
`77`		`- Assert.Equal(BookingStatus.FINISHED, booking.StatusFor(dateBeforeBookingHasStarted));`
	`77`	`+ Assert.Equal(BookingStatus.FINISHED, booking.StatusFor(dateAfterBookingEnds));`
`78`	`78`	`}`
`79`	`79`	`}`
`80`	`80`	`}`
Original file line number	Diff line number	Diff line change
`@@ -1,12 +1,9 @@`
`1`		`-using System;`
`2`		`-`
`3`		`-namespace CodelyTv.Booking`
	`1`	`+namespace CodelyTv.Booking`
`4`	`2`	`{`
`5`	`3`	`public sealed class BookingId`
`6`	`4`	`{`
`7`	`5`	`private readonly string value;`
`8`	`6`
`9`	`7`	`public BookingId(string value) => this.value = value;`
`10`	`8`	`}`
`11`		`-`
`12`	`9`	`}`