Merge pull request #119 from craig-mcmahon/fix-type-error-in-see-links

Naktibalda · web-flow · commit bb857bd5086f · 2024-02-14T19:27:44.000+02:00
Fix type error when using `seeLink`
diff --git a/src/Codeception/Module/WebDriver.php b/src/Codeception/Module/WebDriver.php
@@ -1367,7 +1367,7 @@ private function filterNodesByHref(string $url, array $nodes): array
         return array_filter(
             $nodes,
             function (WebDriverElement $e) use ($expectedUrl, $absoluteCurrentUrl): bool {
-                $elementHref = Uri::mergeUrls($absoluteCurrentUrl, $e->getAttribute('href'));
+                $elementHref = Uri::mergeUrls($absoluteCurrentUrl, $e->getAttribute('href') ?? '');
                 return $elementHref === $expectedUrl;
             }
         );

Original file line number	Diff line number	Diff line change
`@@ -1367,7 +1367,7 @@ private function filterNodesByHref(string $url, array $nodes): array`
`1367`	`1367`	`return array_filter(`
`1368`	`1368`	`$nodes,`
`1369`	`1369`	`function (WebDriverElement $e) use ($expectedUrl, $absoluteCurrentUrl): bool {`
`1370`		`- $elementHref = Uri::mergeUrls($absoluteCurrentUrl, $e->getAttribute('href'));`
	`1370`	`+ $elementHref = Uri::mergeUrls($absoluteCurrentUrl, $e->getAttribute('href') ?? '');`
`1371`	`1371`	`return $elementHref === $expectedUrl;`
`1372`	`1372`	`}`
`1373`	`1373`	`);`