From 03068a7fb7b6003e7bc79c4bdff1a2164ab7ef75 Mon Sep 17 00:00:00 2001 From: Thomas Landauer Date: Mon, 27 Sep 2021 01:17:04 +0200 Subject: [PATCH 1/2] Updating Cest file location --- CONTRIBUTING.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 53b4a666..9d4ac401 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -82,7 +82,7 @@ Now wait for feedback on your Pull Request. If all is fine and it gets merged... ### 4. Send a Test -- In the test project (`symfony-module-tests`), create a test with the same name as your new method in `tests/Functional/SymfonyModuleCest.php`, following alphabetical order. +- In the test project (`symfony-module-tests`), locate the `/tests/Functional/*Cest.php` file corresponding to the trait. In there, create a new method with the same name as your method in the trait, following alphabetical order. - Run the tests with `vendor/bin/codecept run Functional` command. From bd590475e3330e792b922647155be8044caf66c7 Mon Sep 17 00:00:00 2001 From: Thomas Landauer Date: Mon, 27 Sep 2021 01:20:15 +0200 Subject: [PATCH 2/2] Update CONTRIBUTING.md --- CONTRIBUTING.md | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 9d4ac401..12efdbe9 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -82,7 +82,8 @@ Now wait for feedback on your Pull Request. If all is fine and it gets merged... ### 4. Send a Test -- In the test project (`symfony-module-tests`), locate the `/tests/Functional/*Cest.php` file corresponding to the trait. In there, create a new method with the same name as your method in the trait, following alphabetical order. +- In the test project (`symfony-module-tests`), locate the `/tests/Functional/*Cest.php` file corresponding to the trait. In there, create a new method with the same name as your method in the trait, following alphabetical order. +If your PR fixes an existing issue, put the test into `/tests/Functional/IssuesCest.php`. - Run the tests with `vendor/bin/codecept run Functional` command.