Remove support for PHP 7.1 and PHP 7.2 (#76)

Author: TavoNiievez

.github/workflows/main.yml

@@ -8,11 +8,8 @@ jobs:
 
     strategy:
       matrix:
-        php: [7.1, 7.2, 7.3, 7.4, 8.0]
+        php: [7.3, 7.4, 8.0]
         symfony: [3.4, 4.4, 5]
-        exclude:
-          - php: 7.1
-            symfony: 5
 
     steps:
     - name: Checkout code

composer.json

@@ -16,10 +16,10 @@
     ],
     "minimum-stability": "RC",
     "require": {
-        "php": ">=7.1.3 <9.0",
+        "php": "^7.3 | ^8.0",
+        "ext-json": "*",
         "codeception/lib-innerbrowser": "^1.3",
-        "codeception/codeception": "^4.0",
-        "ext-json": "*"
+        "codeception/codeception": "^4.0"
     },
     "require-dev": {
         "codeception/module-asserts": "^1.3",

readme.md

@@ -4,6 +4,11 @@ A Codeception module for Symfony framework.
 
 [![Actions Status](https://github.com/Codeception/module-symfony/workflows/CI/badge.svg)](https://github.com/Codeception/module-symfony/actions)
 
+## Requirements
+
+* `Symfony 3.4` or higher.
+* `PHP 7.3` or higher.
+
 ## Installation
 
 ```

src/Codeception/Module/Symfony.php

@@ -214,7 +214,7 @@ public function _parts(): array
      */
     protected $persistentServices = [];
 
-    public function _initialize()
+    public function _initialize(): void
     {
         $this->initializeSymfonyCache();
         $this->kernelClass = $this->getKernelClass();
@@ -235,7 +235,7 @@ public function _initialize()
     /**
      * Require Symfony's bootstrap.php.cache
      */
-    private function initializeSymfonyCache()
+    private function initializeSymfonyCache(): void
     {
         $cache = Configuration::projectDir() . $this->config['var_path'] . DIRECTORY_SEPARATOR . 'bootstrap.php.cache';
 
@@ -249,7 +249,7 @@ private function initializeSymfonyCache()
      *
      * @param TestInterface $test
      */
-    public function _before(TestInterface $test)
+    public function _before(TestInterface $test): void
     {
         $this->persistentServices = array_merge($this->persistentServices, $this->permanentServices);
         $this->client = new SymfonyConnector($this->kernel, $this->persistentServices, $this->config['rebootable_client']);
@@ -260,15 +260,15 @@ public function _before(TestInterface $test)
      *
      * @param TestInterface $test
      */
-    public function _after(TestInterface $test)
+    public function _after(TestInterface $test): void
     {
         foreach (array_keys($this->permanentServices) as $serviceName) {
             $this->permanentServices[$serviceName] = $this->grabService($serviceName);
         }
         parent::_after($test);
     }
 
-    protected function onReconfigure($settings = [])
+    protected function onReconfigure($settings = []): void
     {
 
         parent::_beforeSuite($settings);
@@ -307,7 +307,7 @@ public function _getEntityManager()
      *
      * @return ContainerInterface|mixed
      */
-    public function _getContainer()
+    public function _getContainer(): ContainerInterface
     {
         $container = $this->kernel->getContainer();
 
@@ -337,18 +337,18 @@ protected function getKernelClass(): string
             throw new ModuleRequireException(
                 self::class,
                 "Can't load Kernel from $path.\n"
-                . "Directory does not exists. Use `app_path` parameter to provide valid application path"
+                . 'Directory does not exists. Use `app_path` parameter to provide valid application path'
             );
         }
 
         $finder = new Finder();
         $finder->name('*Kernel.php')->depth('0')->in($path);
         $results = iterator_to_array($finder);
-        if (count($results) === 0) {
+        if ($results === []) {
             throw new ModuleRequireException(
                 self::class,
                 "File with Kernel class was not found at $path. "
-                . "Specify directory where file with Kernel class for your application is located with `app_path` parameter."
+                . 'Specify directory where file with Kernel class for your application is located with `app_path` parameter.'
             );
         }
 
@@ -376,7 +376,7 @@ protected function getKernelClass(): string
         throw new ModuleRequireException(
             self::class,
             "Kernel class was not found in $file. "
-            . "Specify directory where file with Kernel class for your application is located with `app_path` parameter."
+            . 'Specify directory where file with Kernel class for your application is located with `app_path` parameter.'
         );
     }
 
@@ -389,7 +389,7 @@ public function persistService(string $serviceName): void
     {
         $service = $this->grabService($serviceName);
         $this->persistentServices[$serviceName] = $service;
-        if ($this->client) {
+        if ($this->client instanceof SymfonyConnector) {
             $this->client->persistentServices[$serviceName] = $service;
         }
     }
@@ -405,7 +405,7 @@ public function persistPermanentService(string $serviceName): void
         $service = $this->grabService($serviceName);
         $this->persistentServices[$serviceName] = $service;
         $this->permanentServices[$serviceName] = $service;
-        if ($this->client) {
+        if ($this->client instanceof SymfonyConnector) {
             $this->client->persistentServices[$serviceName] = $service;
         }
     }
@@ -423,7 +423,7 @@ public function unpersistService(string $serviceName): void
         if (isset($this->permanentServices[$serviceName])) {
             unset($this->permanentServices[$serviceName]);
         }
-        if ($this->client && isset($this->client->persistentServices[$serviceName])) {
+        if ($this->client instanceof SymfonyConnector && isset($this->client->persistentServices[$serviceName])) {
             unset($this->client->persistentServices[$serviceName]);
         }
     }
@@ -452,7 +452,7 @@ public function amOnRoute(string $routeName, array $params = []): void
     {
         /** @var RouterInterface $router */
         $router = $this->grabService('router');
-        if (!$router->getRouteCollection()->get($routeName)) {
+        if ($router->getRouteCollection()->get($routeName) === null) {
             $this->fail(sprintf('Route with name "%s" does not exists.', $routeName));
         }
         $url = $router->generate($routeName, $params);
@@ -475,7 +475,7 @@ public function seeCurrentRouteIs(string $routeName, array $params = []): void
     {
         /** @var RouterInterface $router */
         $router = $this->grabService('router');
-        if (!$router->getRouteCollection()->get($routeName)) {
+        if ($router->getRouteCollection()->get($routeName) === null) {
             $this->fail(sprintf('Route with name "%s" does not exists.', $routeName));
         }
 
@@ -506,7 +506,7 @@ public function seeInCurrentRoute(string $routeName): void
     {
         /** @var RouterInterface $router */
         $router = $this->grabService('router');
-        if (!$router->getRouteCollection()->get($routeName)) {
+        if ($router->getRouteCollection()->get($routeName) === null) {
             $this->fail(sprintf('Route with name "%s" does not exists.', $routeName));
         }
 
@@ -834,7 +834,7 @@ protected function getInternalDomains(): array
      */
     public function rebootClientKernel(): void
     {
-        if ($this->client) {
+        if ($this->client instanceof SymfonyConnector) {
             $this->client->rebootKernel();
         }
     }
@@ -1076,7 +1076,7 @@ public function seeAuthentication(): void
 
         $user = $security->getUser();
 
-        if (!$user) {
+        if ($user === null) {
             $this->fail('There is no user in session');
         }
 
@@ -1129,7 +1129,7 @@ public function seeRememberedAuthentication(): void
 
         $user = $security->getUser();
 
-        if (!$user) {
+        if ($user === null) {
             $this->fail('There is no user in session');
         }
 
@@ -1172,14 +1172,14 @@ public function seeUserHasRole(string $role): void
 
         $user = $security->getUser();
 
-        if (!$user) {
+        if ($user === null) {
             $this->fail('There is no user in session');
         }
 
         $this->assertTrue(
             $security->isGranted($role),
             sprintf(
-                "User %s has no role %s",
+                'User %s has no role %s',
                 $user->getUsername(),
                 $role
             )
@@ -1373,7 +1373,8 @@ public function seeUserPasswordDoesNotNeedRehash(UserInterface $user = null): vo
         if ($user === null) {
             /** @var Security $security */
             $security = $this->grabService('security.helper');
-            if (!$user = $security->getUser()) {
+            $user = $security->getUser();
+            if ($user === null) {
                 $this->fail('No user found to validate');
             }
         }