Skip to content

Commit f35b4a2

Browse files
authored
Test against PHP 8.4 (#13)
* Test against PHP 8.4 * Bump actions/checkout dependency * Drop support for PHP 8.0 * Remove superfluous check
1 parent bc7c96a commit f35b4a2

File tree

3 files changed

+7
-9
lines changed

3 files changed

+7
-9
lines changed

.github/workflows/main.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,11 +8,11 @@ jobs:
88

99
strategy:
1010
matrix:
11-
php: [8.0, 8.1, 8.2, 8.3]
11+
php: [8.1, 8.2, 8.3, 8.4]
1212

1313
steps:
1414
- name: Checkout code
15-
uses: actions/checkout@v3
15+
uses: actions/checkout@v4
1616

1717
- name: Setup PHP
1818
uses: shivammathur/setup-php@v2

composer.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
],
1414
"homepage": "https://codeception.com/",
1515
"require": {
16-
"php": "^8.0",
16+
"php": "^8.1",
1717
"ext-mbstring": "*",
1818
"guzzlehttp/psr7": "^2.0",
1919
"phpunit/phpunit": "^9.5 | ^10.0 | ^11.0",

src/Util/Locator.php

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -338,11 +338,9 @@ public static function humanReadableString(WebDriverBy|array|string $selector):
338338
$locator = $selector[$type];
339339
return "{$type} '{$locator}'";
340340
}
341-
if (class_exists('\Facebook\WebDriver\WebDriverBy') && $selector instanceof WebDriverBy) {
342-
$type = $selector->getMechanism();
343-
$locator = $selector->getValue();
344-
return "{$type} '{$locator}'";
345-
}
346-
throw new InvalidArgumentException("Unrecognized selector");
341+
342+
$type = $selector->getMechanism();
343+
$locator = $selector->getValue();
344+
return "{$type} '{$locator}'";
347345
}
348346
}

0 commit comments

Comments
 (0)