From c4f3223ac9c69b40ce73bd196bd1369efb573ed4 Mon Sep 17 00:00:00 2001 From: Benjamin Fahl Date: Tue, 14 Dec 2021 17:13:09 +0100 Subject: [PATCH 1/2] fix: prevent "explode" error when responseContentType is null --- src/Codeception/Lib/InnerBrowser.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Codeception/Lib/InnerBrowser.php b/src/Codeception/Lib/InnerBrowser.php index 181f5f0..c904076 100644 --- a/src/Codeception/Lib/InnerBrowser.php +++ b/src/Codeception/Lib/InnerBrowser.php @@ -97,7 +97,7 @@ public function _failed(TestInterface $test, $fail) $internalResponse = false; } - $responseContentType = $internalResponse ? $internalResponse->getHeader('content-type') : ''; + $responseContentType = $internalResponse ? $internalResponse->getHeader('content-type') ?? '': ''; [$responseMimeType] = explode(';', $responseContentType); $extension = $extensions[$responseMimeType] ?? 'html'; From ff0c72ba6f23538250e3cea80ee971621fb916e4 Mon Sep 17 00:00:00 2001 From: Ben Date: Tue, 21 Dec 2021 11:10:47 +0100 Subject: [PATCH 2/2] Update src/Codeception/Lib/InnerBrowser.php - always use casting to string to hit more cases Co-authored-by: Gustavo Nieves <64917965+TavoNiievez@users.noreply.github.com> --- src/Codeception/Lib/InnerBrowser.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Codeception/Lib/InnerBrowser.php b/src/Codeception/Lib/InnerBrowser.php index c904076..d039c61 100644 --- a/src/Codeception/Lib/InnerBrowser.php +++ b/src/Codeception/Lib/InnerBrowser.php @@ -97,7 +97,7 @@ public function _failed(TestInterface $test, $fail) $internalResponse = false; } - $responseContentType = $internalResponse ? $internalResponse->getHeader('content-type') ?? '': ''; + $responseContentType = $internalResponse ? (string) $internalResponse->getHeader('content-type') : ''; [$responseMimeType] = explode(';', $responseContentType); $extension = $extensions[$responseMimeType] ?? 'html';