Skip to content

Commit b33aebe

Browse files
authored
Code standards updated to PHP 7.3 (#40)
* Code standards updated to PHP 7.3 * Support for Codeception 5 * AssertSame instead of AssertEquals
1 parent 4b0d89b commit b33aebe

File tree

12 files changed

+342
-345
lines changed

12 files changed

+342
-345
lines changed

.github/workflows/main.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ jobs:
88

99
strategy:
1010
matrix:
11-
php: [5.6, 7.0, 7.1, 7.2, 7.3, 7.4, 8.0]
11+
php: [7.3, 7.4, 8.0]
1212

1313
steps:
1414
- name: Checkout code

composer.json

Lines changed: 43 additions & 42 deletions
Original file line numberDiff line numberDiff line change
@@ -1,44 +1,45 @@
11
{
2-
"name":"codeception/lib-innerbrowser",
3-
"description":"Parent library for all Codeception framework modules and PhpBrowser",
4-
"keywords":["codeception"],
5-
"homepage":"https://codeception.com/",
6-
"type":"library",
7-
"license":"MIT",
8-
"authors":[
9-
{
10-
"name":"Michael Bodnarchuk",
11-
"email":"davert@mail.ua",
12-
"homepage":"http://codegyre.com"
13-
},
14-
{
15-
"name":"Gintautas Miselis"
16-
}
17-
],
18-
"minimum-stability": "RC",
19-
20-
"require": {
21-
"php": ">=5.6.0 <9.0",
22-
"codeception/codeception": "*@dev",
23-
"symfony/browser-kit": ">=2.7 <6.0",
24-
"symfony/dom-crawler": ">=2.7 <6.0",
25-
"ext-mbstring": "*",
26-
"ext-dom": "*",
27-
"ext-json": "*"
28-
},
29-
"require-dev": {
30-
"codeception/util-universalframework": "dev-master"
31-
},
32-
"conflict": {
33-
"codeception/codeception": "<4.0"
34-
},
35-
"autoload":{
36-
"classmap": ["src/"]
37-
},
38-
"config": {
39-
"classmap-authoritative": true
40-
},
41-
"scripts": {
42-
"test": "codecept run --coverage-xml"
43-
}
2+
"name": "codeception/lib-innerbrowser",
3+
"description": "Parent library for all Codeception framework modules and PhpBrowser",
4+
"keywords": [ "codeception" ],
5+
"homepage": "https://codeception.com/",
6+
"type": "library",
7+
"license": "MIT",
8+
"authors": [
9+
{
10+
"name": "Michael Bodnarchuk",
11+
"email": "davert@mail.ua",
12+
"homepage": "https://codegyre.com"
13+
},
14+
{
15+
"name": "Gintautas Miselis"
16+
}
17+
],
18+
"minimum-stability": "RC",
19+
"require": {
20+
"php": "^7.3 || ^8.0",
21+
"ext-dom": "*",
22+
"ext-json": "*",
23+
"ext-mbstring": "*",
24+
"codeception/codeception": "^5.0 || *@dev",
25+
"symfony/browser-kit": ">=4.4 <6.0",
26+
"symfony/dom-crawler": ">=4.4 <6.0"
27+
},
28+
"require-dev": {
29+
"codeception/util-universalframework": "dev-master"
30+
},
31+
"conflict": {
32+
"codeception/codeception": "<5.0"
33+
},
34+
"autoload": {
35+
"classmap": [
36+
"src/"
37+
]
38+
},
39+
"config": {
40+
"classmap-authoritative": true
41+
},
42+
"scripts": {
43+
"test": "codecept run --coverage-xml"
44+
}
4445
}

readme.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,10 @@ Parent library for all Codeception framework modules and PhpBrowser.
77
[![Total Downloads](https://poser.pugx.org/codeception/lib-innerbrowser/downloads)](https://packagist.org/packages/codeception/lib-innerbrowser)
88
[![License](https://poser.pugx.org/codeception/lib-innerbrowser/license)](/LICENSE)
99

10+
## Requirements
11+
12+
* `PHP 7.3` or higher.
13+
1014
## Installation
1115

1216
```
Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,11 @@
11
<?php
22

3+
declare(strict_types=1);
4+
35
namespace Codeception\Exception;
46

5-
class ExternalUrlException extends \Exception
7+
use Exception;
8+
9+
class ExternalUrlException extends Exception
610
{
711
}

src/Codeception/Lib/Framework.php

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,21 +1,20 @@
11
<?php
22

3+
declare(strict_types=1);
4+
35
namespace Codeception\Lib;
46

57
/**
68
* Abstract module for PHP frameworks connected via Symfony BrowserKit components
79
* Each framework is connected with it's own connector defined in \Codeception\Lib\Connector
810
* Each module for framework should extend this class.
9-
*
1011
*/
1112
abstract class Framework extends InnerBrowser
1213
{
1314
/**
1415
* Returns a list of recognized domain names
15-
*
16-
* @return array
1716
*/
18-
protected function getInternalDomains()
17+
protected function getInternalDomains(): array
1918
{
2019
return [];
2120
}

0 commit comments

Comments
 (0)