Added more typehints

Author: TavoNiievez

src/Codeception/Lib/InnerBrowser.php

@@ -23,6 +23,7 @@
 use Codeception\Util\Uri;
 use DOMDocument;
 use DOMNode;
+use Exception;
 use InvalidArgumentException;
 use LogicException;
 use Symfony\Component\BrowserKit\AbstractBrowser;
@@ -78,7 +79,7 @@ class InnerBrowser extends Module implements Web, PageSourceSaver, ElementLocato
      */
     private $baseUrl;
 
-    public function _failed(TestInterface $test, $fail)
+    public function _failed(TestInterface $test, Exception $fail)
     {
         try {
             if (!$this->client || !$this->client->getInternalResponse()) {
@@ -260,7 +261,7 @@ protected function clientRequest(
         return $this->redirectIfNecessary($result, $maxRedirects, 0);
     }
 
-    protected function isInternalDomain($domain): bool
+    protected function isInternalDomain(string $domain): bool
     {
         if ($this->internalDomains === null) {
             $this->internalDomains = $this->getInternalDomains();
@@ -591,8 +592,9 @@ public function seeLink($text, $url = null)
         $this->assertTrue(true);
     }
 
-    public function dontSeeLink($text, $url = '')
+    public function dontSeeLink($text, $url = null)
     {
+        $url = (string) $url;
         $crawler = $this->getCrawler()->selectLink($text);
         if (!$url && $crawler->count() > 0) {
             $this->fail("Link containing text '$text' was found in page " . $this->_getCurrentUri());
@@ -1294,10 +1296,10 @@ public function attachFile($field, $filename)
      * Sends an ajax GET request with the passed parameters.
      * See `sendAjaxPostRequest()`
      *
-     * @param $uri
+     * @param string $uri
      * @param array $params
      */
-    public function sendAjaxGetRequest($uri, array $params = []): void
+    public function sendAjaxGetRequest(string $uri, array $params = []): void
     {
         $this->sendAjaxRequest('GET', $uri, $params);
     }
@@ -1339,11 +1341,11 @@ public function sendAjaxPostRequest(string $uri, array $params = []): void
      * $I->sendAjaxRequest('PUT', '/posts/7', ['title' => 'new title']);
      * ```
      *
-     * @param $method
-     * @param $uri
+     * @param string $method
+     * @param string $uri
      * @param array $params
      */
-    public function sendAjaxRequest($method, $uri, array $params = []): void
+    public function sendAjaxRequest(string $method, string $uri, array $params = []): void
     {
         $this->clientRequest($method, $uri, $params, [], ['HTTP_X_REQUESTED_WITH' => 'XMLHttpRequest'], null, false);
     }
@@ -1802,7 +1804,7 @@ protected function assertDomNotContains($nodes, string $message, string $text =
         $this->assertThat($nodes, $constraint, $message);
     }
 
-    protected function assertPageContains($needle, string $message = ''): void
+    protected function assertPageContains(string $needle, string $message = ''): void
     {
         $constraint = new PageConstraint($needle, $this->_getCurrentUri());
         $this->assertThat(
@@ -1812,10 +1814,7 @@ protected function assertPageContains($needle, string $message = ''): void
         );
     }
 
-    /**
-     * @param string $message
-     */
-    protected function assertPageNotContains($needle, string $message = ''): void
+    protected function assertPageNotContains(string $needle, string $message = ''): void
     {
         $constraint = new PageConstraint($needle, $this->_getCurrentUri());
         $this->assertThatItsNot(
@@ -1825,10 +1824,7 @@ protected function assertPageNotContains($needle, string $message = ''): void
         );
     }
 
-    /**
-     * @param string $message
-     */
-    protected function assertPageSourceContains($needle, string $message = ''): void
+    protected function assertPageSourceContains(string $needle, string $message = ''): void
     {
         $constraint = new PageConstraint($needle, $this->_getCurrentUri());
         $this->assertThat(
@@ -1838,10 +1834,7 @@ protected function assertPageSourceContains($needle, string $message = ''): void
         );
     }
 
-    /**
-     * @param string $message
-     */
-    protected function assertPageSourceNotContains($needle, string $message = ''): void
+    protected function assertPageSourceNotContains(string $needle, string $message = ''): void
     {
         $constraint = new PageConstraint($needle, $this->_getCurrentUri());
         $this->assertThatItsNot(
@@ -1872,23 +1865,15 @@ protected function matchFormField(string $name, $form, FormField $dynamicField)
         throw new TestRuntimeException("None of form fields by {$name}[] were not matched");
     }
 
-    /**
-     * @param $locator
-     * @return SymfonyCrawler
-     */
-    protected function filterByCSS($locator): SymfonyCrawler
+    protected function filterByCSS(string $locator): SymfonyCrawler
     {
         if (!Locator::isCSS($locator)) {
             throw new MalformedLocatorException($locator, 'css');
         }
         return $this->getCrawler()->filter($locator);
     }
 
-    /**
-     * @param $locator
-     * @return SymfonyCrawler
-     */
-    protected function filterByXPath($locator): SymfonyCrawler
+    protected function filterByXPath(string $locator): SymfonyCrawler
     {
         if (!Locator::isXPath($locator)) {
             throw new MalformedLocatorException($locator, 'xpath');