signup fixed

Author: Chmod351

README.md

@@ -63,9 +63,8 @@ CLIENTID:your_google_oauth_cliendId
 ## Tests
 
 - The aplication was tested with [Jest](https://jestjs.io/) and [Supertest](https://www.npmjs.com/package/supertest)
-
 ```
-npm test
+npm run test
 
 ```
 

package.json

@@ -5,7 +5,7 @@
   "main": "index.js",
   "type": "module",
   "scripts": {
-    "test": "jest",
+    "test": "node --experimental-vm-modules node_modules/jest/bin/jest.js",
     "start": "node index.js",
     "dev": "nodemon index.js"
   },

server/application/users/usersControllers.js

@@ -1,17 +1,8 @@
 import userService from './usersService.js';
 const maxAge = 24 * 60 * 60 * 1000;
 
-const usersController = {
-  signIn,
-  signUp,
-  getUser,
-  getStat,
-  googleToken,
-  findByEmail,
-};
-
 function signIn(req, res, next) {
-console.log("aca");
+  console.log('aca');
   userService
     .signIn(req.body)
     .then(({ user, sendToken }) => {
@@ -31,6 +22,7 @@ console.log("aca");
 }
 
 function signUp(req, res, next) {
+  console.log('controller');
   userService
     .signUp(req.body)
     .then((user) => res.json(user))
@@ -65,4 +57,12 @@ function googleToken(req, res, next) {
     .catch((error) => next(error));
 }
 
+const usersController = {
+  signIn,
+  signUp,
+  getUser,
+  getStat,
+  googleToken,
+  findByEmail,
+};
 export default usersController;

server/application/users/usersService.js

@@ -66,22 +66,21 @@ async function checkLength(item, num) {
 
 async function signUp(user) {
   const allowedFields = ['email', 'password', 'username'];
-
   const filteredUser = Object.keys(user) //check if user contains allowedFields
     .filter((key) => allowedFields.includes(key))
     .reduce((obj, key) => {
       obj[key] = user[key];
       return obj;
     }, {});
+  await checkLength(filteredUser.password, 8);
 
-  const validatePass = await checkLength(filteredUser.password, 8);
-  if (validatePass) {
+  try {
     const encryptPassword = await encrypt.hashPassword(filteredUser.password);
     const createUser = new User({ ...filteredUser, password: encryptPassword });
     const newUser = await createUser.save();
     return newUser;
-  } else {
-    throw new BadRequestError('password does not match');
+  } catch (error) {
+    throw new BadRequestError(error.message);
   }
 }
 

server/tests/componentsTests/usersControllers.test.js

@@ -0,0 +1,14 @@
+import { expect } from 'chai';
+import usersController from '../../application/users/usersControllers';
+
+describe('this tests should return succesfull responses', () => {
+  it('should return an user with status code 200', async () => {
+    const body = {
+      email: '12345@hotmail.com',
+      password:
+        '@ztCU^d3Q9%JXkN!toR&fVniRupNySHo3w^6tP*VfG9vuoH9u#zod42JC6Y6Poq',
+    };
+    const response = usersController.signIn(body);
+    console.log(response);
+  });
+});

server/tests/serviceTests/purchases.test.js

@@ -1,102 +1 @@
-import request from 'supertest';
-import { Router } from 'express';
-import cartController from './shopingCartController.js';
-import authMiddleware from '../helpers/jwt.js';
-import adminCheck from '../helpers/adminCheck.js';
-import { cleanBody } from '../helpers/sanitizer.js';
 
-const router = Router();
-
-// Mock authMiddleware and adminCheck
-jest.mock('../helpers/jwt.js', () => jest.fn());
-jest.mock('../helpers/adminCheck.js', () => jest.fn());
-
-// Mock cartController methods
-cartController.createCart = jest.fn();
-cartController.getAll = jest.fn();
-cartController.getUserCart = jest.fn();
-cartController.editCart = jest.fn();
-cartController.deleteCart = jest.fn();
-
-// Mock router methods
-router.post = jest.fn();
-router.get = jest.fn();
-router.put = jest.fn();
-router.delete = jest.fn();
-
-describe('Cart Routes', () => {
-  beforeEach(() => {
-    jest.clearAllMocks();
-  });
-
-  it('should call the appropriate methods when POST /create is called', async () => {
-    router.post('/create', authMiddleware, cleanBody, cartController.createCart);
-
-    const req = { body: { products: [] }, user: { id: 'user_id' } };
-    const res = { json: jest.fn() };
-    const next = jest.fn();
-
-    await request(router).post('/create').send(req.body).set('Authorization', 'Bearer token');
-
-    expect(authMiddleware).toHaveBeenCalled();
-    expect(cleanBody).toHaveBeenCalled();
-    expect(cartController.createCart).toHaveBeenCalledWith(req, res, next);
-  });
-
-  it('should call the appropriate methods when GET /getAll is called', async () => {
-    router.get('/getAll', authMiddleware, adminCheck, cartController.getAll);
-
-    const req = { query: { page: '1', size: '10' } };
-    const res = { json: jest.fn() };
-    const next = jest.fn();
-
-    await request(router).get('/getAll').query(req.query).set('Authorization', 'Bearer token');
-
-    expect(authMiddleware).toHaveBeenCalled();
-    expect(adminCheck).toHaveBeenCalled();
-    expect(cartController.getAll).toHaveBeenCalledWith(req, res, next);
-  });
-
-  it('should call the appropriate methods when GET /:userId is called', async () => {
-    router.get('/:userId', authMiddleware, cartController.getUserCart);
-
-    const req = { params: { userId: 'user_id' } };
-    const res = { json: jest.fn() };
-    const next = jest.fn();
-
-    await request(router).get(`/${req.params.userId}`).set('Authorization', 'Bearer token');
-
-    expect(authMiddleware).toHaveBeenCalled();
-    expect(cartController.getUserCart).toHaveBeenCalledWith(req, res, next);
-  });
-
-  it('should call the appropriate methods when PUT /update/:cartId is called', async () => {
-    router.put('/update/:cartId', authMiddleware, cleanBody, cartController.editCart);
-
-    const req = { body: {}, params: { cartId: 'cart_id' }, user: { id: 'user_id' } };
-    const res = { json: jest.fn() };
-    const next = jest.fn();
-
-    await request(router)
-      .put(`/update/${req.params.cartId}`)
-      .send(req.body)
-      .set('Authorization', 'Bearer token');
-
-    expect(authMiddleware).toHaveBeenCalled();
-    expect(cleanBody).toHaveBeenCalled();
-    expect(cartController.editCart).toHaveBeenCalledWith(req, res, next);
-  });
-
-  it('should call the appropriate methods when DELETE /delete/:cartId is called', async () => {
-    router.delete('/delete/:cartId', authMiddleware, cartController.deleteCart);
-
-    const req ={ params: { cartId: 'cart_id' }, user: { id: 'user_id' } };
-    const res = { json: jest.fn() };
-    const next = jest.fn();
-
-    await request(router).delete(`/delete/${req.params.cartId}`).set('Authorization', 'Bearer token');
-
-    expect(authMiddleware).toHaveBeenCalled();
-    expect(cartController.deleteCart).toHaveBeenCalledWith(req, res, next);
-  });
-});