ext/opcache: add code comment and warning on Windows

MaxKellermann · MaxKellermann · commit 485c5bb37488 · 2023-01-16T12:34:56.000+01:00
kill_all_lockers() is not implemented on Windows, thus the code is incomplete and broken. See php#10276 (comment) for the explanation.
diff --git a/ext/opcache/ZendAccelerator.c b/ext/opcache/ZendAccelerator.c
@@ -896,6 +896,10 @@ static inline void kill_all_lockers(struct flock *mem_usage_check)
 static inline int accel_is_inactive(void)
 {
 #ifdef ZEND_WIN32
+	/* TODO: the Windows-specific code path is broken because
+	   kill_all_lockers() is not implemented on Windows, and thus
+	   hanging workers are never killed and restarted; not ready
+	   for production use! */
 	if (LOCKVAL(mem_usage) == 0) {
 		return SUCCESS;
 	}
diff --git a/ext/opcache/config.w32 b/ext/opcache/config.w32
@@ -41,5 +41,6 @@ if (PHP_OPCACHE != "no") {
 
 	ADD_FLAG('CFLAGS_OPCACHE', "/I " + configure_module_dirname);
 
+        WARNING("opcache is known to be broken on Windows");
 }
 

Original file line number	Diff line number	Diff line change
`@@ -896,6 +896,10 @@ static inline void kill_all_lockers(struct flock *mem_usage_check)`
`896`	`896`	`static inline int accel_is_inactive(void)`
`897`	`897`	`{`
`898`	`898`	`#ifdef ZEND_WIN32`
	`899`	`+ /* TODO: the Windows-specific code path is broken because`
	`900`	`+ kill_all_lockers() is not implemented on Windows, and thus`
	`901`	`+ hanging workers are never killed and restarted; not ready`
	`902`	`+ for production use! */`
`899`	`903`	`if (LOCKVAL(mem_usage) == 0) {`
`900`	`904`	`return SUCCESS;`
`901`	`905`	`}`
Original file line number	Diff line number	Diff line change
`@@ -41,5 +41,6 @@ if (PHP_OPCACHE != "no") {`
`41`	`41`
`42`	`42`	`ADD_FLAG('CFLAGS_OPCACHE', "/I " + configure_module_dirname);`
`43`	`43`
	`44`	`+ WARNING("opcache is known to be broken on Windows");`
`44`	`45`	`}`
`45`	`46`