Apply suggestions from code review

tony-p · facontidavide · web-flow · commit e85eb03b3663 · 2024-04-05T16:18:56.000+02:00
style: update from review

Co-authored-by: Davide Faconti &lt;davide.faconti@gmail.com&gt;
diff --git a/behaviortree_ros2/include/behaviortree_ros2/bt_topic_sub_node.hpp b/behaviortree_ros2/include/behaviortree_ros2/bt_topic_sub_node.hpp
@@ -76,7 +76,7 @@ class RosTopicSubNode : public BT::ConditionNode
     rclcpp::CallbackGroup::SharedPtr callback_group;
     rclcpp::executors::SingleThreadedExecutor callback_group_executor;
     boost::signals2::signal<void (const std::shared_ptr<TopicT>)> broadcaster;
-    std::shared_ptr<TopicT> last_msg = nullptr;
+    std::shared_ptr<TopicT> last_msg;
 
 
   };
@@ -319,7 +319,7 @@ template<class T> inline
   auto status = CheckStatus (onTick(last_msg_));
   if (clearProcessedMessage())
   {
-    last_msg_ = nullptr;
+    last_msg_.reset();
   }
   return status;
 }

Original file line number	Diff line number	Diff line change
`@@ -76,7 +76,7 @@ class RosTopicSubNode : public BT::ConditionNode`
`76`	`76`	`rclcpp::CallbackGroup::SharedPtr callback_group;`
`77`	`77`	`rclcpp::executors::SingleThreadedExecutor callback_group_executor;`
`78`	`78`	`boost::signals2::signal<void (const std::shared_ptr<TopicT>)> broadcaster;`
`79`		`- std::shared_ptr<TopicT> last_msg = nullptr;`
	`79`	`+ std::shared_ptr<TopicT> last_msg;`
`80`	`80`
`81`	`81`
`82`	`82`	`};`
`@@ -319,7 +319,7 @@ template<class T> inline`
`319`	`319`	`auto status = CheckStatus (onTick(last_msg_));`
`320`	`320`	`if (clearProcessedMessage())`
`321`	`321`	`{`
`322`		`- last_msg_ = nullptr;`
	`322`	`+ last_msg_.reset();`
`323`	`323`	`}`
`324`	`324`	`return status;`
`325`	`325`	`}`