Null check HashMap's get result in ReactNativeBlobUtilReq instead of checking for key first, to prevent potential async issues

Jonathon Brammer · Jonathon Brammer · commit 172e4a8b5813 · 2023-01-27T16:26:48.000-08:00
diff --git a/android/src/main/java/com/ReactNativeBlobUtil/ReactNativeBlobUtilReq.java b/android/src/main/java/com/ReactNativeBlobUtil/ReactNativeBlobUtilReq.java
@@ -155,8 +155,8 @@ else if (arrayBody != null)
     }
 
     public static void cancelTask(String taskId) {
-        if (taskTable.containsKey(taskId)) {
-            Call call = taskTable.get(taskId);
+        Call call = taskTable.get(taskId);
+        if (call != null) {
             call.cancel();
             taskTable.remove(taskId);
         }

Original file line number	Diff line number	Diff line change
`@@ -155,8 +155,8 @@ else if (arrayBody != null)`
`155`	`155`	`}`
`156`	`156`
`157`	`157`	`public static void cancelTask(String taskId) {`
`158`		`- if (taskTable.containsKey(taskId)) {`
`159`		`- Call call = taskTable.get(taskId);`
	`158`	`+ Call call = taskTable.get(taskId);`
	`159`	`+ if (call != null) {`
`160`	`160`	`call.cancel();`
`161`	`161`	`taskTable.remove(taskId);`
`162`	`162`	`}`