Skip to content

Remove "magic" Service Principal support #112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 11, 2018
Merged

Conversation

daxian-dbw
Copy link
Contributor

@joeyaiello @TylerLeonhardt We agreed on removing Service Principle support, right?

Copy link
Member

@TylerLeonhardt TylerLeonhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah LGTM 🙂

@sspage
Copy link

sspage commented Dec 11, 2018

Will there be another way we can authenticate for commands like Login-AzureRMAccount?

@TylerLeonhardt
Copy link
Member

You will still be able to use Service Principals to authenticate to Azure.

This removes the "magic environment variables" that would log in for you. They're undocumented and should not be relied on.

We are trying to remove the magic and focus on concrete examples.

Expect a doc that gives you the exact code to put in your function (or better yet... Profile.ps1! #110) on how to use Service Principal and/or MSI to authenticate to Azure in your Function app

@sspage
Copy link

sspage commented Dec 11, 2018

Great, thanks. As much as I do like magic, this sounds better. :)

@daxian-dbw daxian-dbw merged commit 6e53357 into dev Dec 11, 2018
@daxian-dbw daxian-dbw deleted the removeServicePrincipal branch December 11, 2018 07:52
@joeyaiello joeyaiello changed the title Remove Service Principal support Remove "magic" Service Principal support Jan 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants