Address review comments

Author: daxian-dbw

docs/cmdlets/Get-OutputBinding.md

@@ -13,7 +13,7 @@ Gets the hashtable of the output bindings set so far.
 ## SYNTAX
 
 ```
-Get-OutputBinding [-Name <String>] [-Purge] [<CommonParameters>]
+Get-OutputBinding [[-Name] <String>] [-Purge] [<CommonParameters>]
 ```
 
 ## DESCRIPTION
@@ -54,10 +54,10 @@ Parameter Sets: (All)
 Aliases:
 
 Required: False
-Position: Named
+Position: 0
 Default value: *
 Accept pipeline input: True (ByPropertyName, ByValue)
-Accept wildcard characters: True
+Accept wildcard characters: False
 ```
 
 ### -Purge

docs/cmdlets/Trace-PipelineObject.md

@@ -13,7 +13,7 @@ Writes the formatted output of the pipeline object to the information stream bef
 ## SYNTAX
 
 ```
-Trace-PipelineObject -InputObject <Object> [<CommonParameters>]
+Trace-PipelineObject [-InputObject] <Object> [<CommonParameters>]
 ```
 
 ## DESCRIPTION
@@ -40,7 +40,7 @@ Parameter Sets: (All)
 Aliases:
 
 Required: True
-Position: Named
+Position: 0
 Default value: None
 Accept pipeline input: True (ByValue)
 Accept wildcard characters: False

src/Public/Commands/GetOutputBindingCommand.cs

@@ -31,7 +31,7 @@ public sealed class GetOutputBindingCommand : PSCmdlet
         /// <summary>
         /// The name of the output binding you want to get. Supports wildcards.
         /// </summary>
-        [Parameter(ValueFromPipeline = true, ValueFromPipelineByPropertyName = true)]
+        [Parameter(Position = 0, ValueFromPipeline = true, ValueFromPipelineByPropertyName = true)]
         [SupportsWildcards]
         [ValidateNotNullOrEmpty]
         public string Name { get; set; } = "*";

src/Public/Commands/TracePipelineObjectCommand.cs

@@ -28,7 +28,7 @@ public sealed class TracePipelineObjectCommand : PSCmdlet
         /// <summary>
         /// The object from pipeline.
         /// </summary>
-        [Parameter(Mandatory = true, ValueFromPipeline = true)]
+        [Parameter(Mandatory = true, Position = 0, ValueFromPipeline = true)]
         public object InputObject { get; set; }
 
         private static PowerShell s_pwsh;

test/Unit/PowerShell/PowerShellManagerTests.cs

@@ -121,6 +121,31 @@ public void InvokeBasicFunctionWorks()
             }
         }
 
+        [Fact]
+        public void InvokeFunctionWithSpecialVariableWorks()
+        {
+            string path = Path.Join(s_funcDirectory, "testBasicFunctionSpecialVariables.ps1");
+            var (functionInfo, testManager) = PrepareFunction(path, string.Empty);
+
+            try
+            {
+                FunctionMetadata.RegisterFunctionMetadata(testManager.InstanceId, functionInfo);
+                Hashtable result = testManager.InvokeFunction(functionInfo, null, s_testInputData);
+
+                // The outputBinding hashtable for the runspace should be cleared after 'InvokeFunction'
+                Hashtable outputBindings = FunctionMetadata.GetOutputBindingHashtable(testManager.InstanceId);
+                Assert.Empty(outputBindings);
+
+                // A PowerShell function should be created fro the Az function.
+                string expectedResult = $"{s_funcDirectory},{path},{functionInfo.DeployedPSFuncName}";
+                Assert.Equal(expectedResult, result[TestOutputBindingName]);
+            }
+            finally
+            {
+                FunctionMetadata.UnregisterFunctionMetadata(testManager.InstanceId);
+            }
+        }
+
         [Fact]
         public void InvokeBasicFunctionWithRequiresWorks()
         {

test/Unit/PowerShell/TestScripts/testBasicFunctionSpecialVariables.ps1

@@ -0,0 +1,13 @@
+#
+# Copyright (c) Microsoft. All rights reserved.
+# Licensed under the MIT license. See LICENSE file in the project root for full license information.
+#
+
+param ($Req)
+
+# Used for logging tests
+Write-Verbose "a log"
+$cmdName = $MyInvocation.MyCommand.Name
+
+$result = "{0},{1},{2}" -f $PSScriptRoot, $PSCommandPath, $cmdName
+Push-OutputBinding -Name res -Value $result