ext/phar: Simplify a return condition in Phar::offsetExists()

Girgias · Girgias · commit d99dc30f3990 · 2024-08-23T14:48:13.000+02:00
diff --git a/ext/phar/phar_object.c b/ext/phar/phar_object.c
@@ -3527,10 +3527,7 @@ PHP_METHOD(Phar, offsetExists)
 		}
 		RETURN_TRUE;
 	} else {
-		if (zend_hash_str_exists(&phar_obj->archive->virtual_dirs, fname, fname_len)) {
-			RETURN_TRUE;
-		}
-		RETURN_FALSE;
+		RETURN_BOOL(zend_hash_str_exists(&phar_obj->archive->virtual_dirs, fname, fname_len));
 	}
 }
 /* }}} */

Original file line number	Diff line number	Diff line change
`@@ -3527,10 +3527,7 @@ PHP_METHOD(Phar, offsetExists)`
`3527`	`3527`	`}`
`3528`	`3528`	`RETURN_TRUE;`
`3529`	`3529`	`} else {`
`3530`		`- if (zend_hash_str_exists(&phar_obj->archive->virtual_dirs, fname, fname_len)) {`
`3531`		`- RETURN_TRUE;`
`3532`		`- }`
`3533`		`- RETURN_FALSE;`
	`3530`	`+ RETURN_BOOL(zend_hash_str_exists(&phar_obj->archive->virtual_dirs, fname, fname_len));`
`3534`	`3531`	`}`
`3535`	`3532`	`}`
`3536`	`3533`	`/* }}} */`