t

Author: Ayesh

.github/workflows/styling.yml

@@ -40,15 +40,15 @@ concurrency:
   cancel-in-progress: true
 jobs:
   CODE_FORMATTING_CHECK:
-    name: CODE_FORMATTING_CHECK
+    name: Code formatting check
 #    if: github.repository_owner == 'php' || github.event_name == 'pull_request'
     runs-on: ubuntu-latest
     steps:
-      - name: git checkout
+      - name: Checkout repository
         uses: actions/checkout@v4
         with:
           fetch-depth: 0
-      - name: apt
+      - name: Install packages
         run: |
           set -x
           sudo apt-get update
@@ -57,37 +57,18 @@ jobs:
             clang-format \
             php-cli \
             netcat-openbsd
-      - name: check code formatting
+      - name: Check code formatting
         run: |
           set -x
-          git fetch origin master
-          git diff origin/master > ../master.diff
-          if [ -f scripts/dev/format_pull_request.php ]; then
-            cp scripts/dev/format_pull_request.php ..
-          fi
-          git checkout master
-          if [ -f scripts/dev/format_pull_request.php ]; then
-            cp scripts/dev/format_pull_request.php ..
-          fi
-          if [ ! -f ../format_pull_request.php ]; then
-            echo "error: format_pull_request.php does not exist" 1>&2
-            exit 1
-          fi
-          git reset --hard origin/master
-          php ../format_pull_request.php ../master.diff > ../formatted.diff
-          if [ -s ../formatted.diff ]; then
-            cat ../formatted.diff
-            echo "code formatting check failed :("
-            patch_url=$(cat ../formatted.diff | nc termbin.com 9999)
-            echo "Please run"
-            echo "curl $patch_url | git apply -v"
-            exit 1
-          else
-            echo "code formatting check succeeded :)"
-            exit 0
-          fi
+          echo "foobar" > format.patch
       - name: 'Upload artifacts'
         uses: actions/upload-artifact@v4
         with:
           name: 'format.patch'
-          path: ../formatted.diff
+          path: format.patch
+          if-no-files-found: ignore
+      - name: 'Show summary'
+        run: |
+          echo 'Artifact ID is ${{ steps.artifact-upload-step.outputs.artifact-id }}'
+          echo 'Artifact ID is ${{ steps.artifact-upload-step.outputs.artifact-url }}'
+          cat 'Run curl ${{ steps.artifact-upload-step.outputs.artifact-url }} | git patch apply' > $GITHUB_STEP_SUMMARY

scripts/dev/format_pull_request.php

@@ -14,12 +14,12 @@
     $argv = array_values($argv);
     $argc = count($argv);
 }
-if ($argc !== 2) {
+if ($argc !== 2 || in_array('--help', $argv, true)) {
     ob_start();
     echo "Usage: php {$argv[0]} [diff-uri]\n";
     echo "example:\nphp {$argv[0]} " . escapeshellarg('https://github.com/php/php-src/pull/13401.diff') . "\n";
     fwrite(STDERR, ob_get_clean());
-    exit(1);
+    exit(in_array('--help', $argv, true) === true ? 0 : 1);
 }
 // check if we're already in php-src
 if (is_dir("Zend")) {