From dab5aa083295b79b54f96f5e8091422d025ada9d Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?H=C3=A5kon=20L=C3=B8vdal?= Date: Sun, 25 Dec 2022 23:57:06 +0100 Subject: [PATCH 1/4] Update centos/rhel comment Yum is replaced with dnf since centos/rhel 8. --- CONTRIBUTING.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index ae677bd1..c0986ac1 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -18,8 +18,8 @@ Pull requests will trigger a CI job. The following two commands will be expecte ```shell apt-get install ruby ruby-dev # For Debian/Ubuntu -dnf install ruby ruby-devel # For Fedora -yum install ruby ruby-devel # For Centos/RHEL +dnf install ruby ruby-devel # For Fedora/newer Centos/RHEL +yum install ruby ruby-devel # For older Centos/RHEL gem install bundler ``` From 5d9ebbd25673d2ff609e602e51a53741a5a90c56 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?H=C3=A5kon=20L=C3=B8vdal?= Date: Sun, 25 Dec 2022 23:57:43 +0100 Subject: [PATCH 2/4] Give example of how to run unit test for just one file --- CONTRIBUTING.md | 1 + 1 file changed, 1 insertion(+) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index c0986ac1..c0793853 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -13,6 +13,7 @@ Pull requests will trigger a CI job. The following two commands will be expecte * `bundle exec rubocop -D .` - code style tests * `bundle exec rspec` - functional tests +* `bundle exec rspec spec/some_file_spec.rb` - functional tests for just some file If you do not already have a working ruby development environment set up, run the following commands: From 63510a9ddbbb1b852bc2d428dbf8175eebd833e7 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?H=C3=A5kon=20L=C3=B8vdal?= Date: Thu, 10 Feb 2022 23:44:32 +0100 Subject: [PATCH 3/4] Spelling correction --- CHANGELOG.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index e4979a3f..f46f1042 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -160,7 +160,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/). ## [0.4.0] - 2020-11-21 ### Added - `arduino_ci_remote.rb` CLI switch `--skip-examples-compilation` -- Add support for `diditalPinToPort()`, `digitalPinToBitMask()`, `portOutputRegister()`, and `portInputRegister()` +- Add support for `digitalPinToPort()`, `digitalPinToBitMask()`, `portOutputRegister()`, and `portInputRegister()` - `CppLibrary.header_files` to find header files - `LibraryProperties` to read metadata from Arduino libraries - `CppLibrary.library_properties_path`, `CppLibrary.library_properties?`, `CppLibrary.library_properties` to expose library properties of a Cpp library From 7cba652bd1fb48cce9ea7ab8c13014c6a79b376f Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?H=C3=A5kon=20L=C3=B8vdal?= Date: Fri, 28 Jan 2022 22:16:07 +0100 Subject: [PATCH 4/4] Add rspec install step to CONTRIBUTING.md --- CONTRIBUTING.md | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index c0793853..317cf257 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -18,10 +18,16 @@ Pull requests will trigger a CI job. The following two commands will be expecte If you do not already have a working ruby development environment set up, run the following commands: ```shell +# One of the following apt-get install ruby ruby-dev # For Debian/Ubuntu dnf install ruby ruby-devel # For Fedora/newer Centos/RHEL yum install ruby ruby-devel # For older Centos/RHEL + +# All below gem install bundler +gem install rspec +# Now you are ready to install dependencies with bundle (as described in the +# README file) and to run unit tests. ``` Be prepared to write tests to accompany any code you would like to see merged.