From 32a021896cfb00f41170cd876ca8684bcb372530 Mon Sep 17 00:00:00 2001 From: James Foster Date: Mon, 15 Feb 2021 10:58:04 -0800 Subject: [PATCH 1/2] Update workflow to test on push. --- .github/workflows/README.md | 2 +- .github/workflows/linux.yaml | 2 +- .github/workflows/macos.yaml | 2 +- .github/workflows/windows.yaml | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/.github/workflows/README.md b/.github/workflows/README.md index 7e1b5195..0e2ce744 100644 --- a/.github/workflows/README.md +++ b/.github/workflows/README.md @@ -7,4 +7,4 @@ In this project, we define a workflow for each target platform. **If you're loo The reason that all platforms are tested in _this_ project is to ensure that, as a framework, `arduino_ci` will run properly on any developer's personal workstation (regardless of OS). -For testing an individual Arduino library in the context of GitHub, [Linux is the cheapest option](https://docs.github.com/en/free-pro-team@latest/github/setting-up-and-managing-billing-and-payments-on-github/about-billing-for-github-actions) and produces results identical to the other OSes. +For testing an individual Arduino library in the context of GitHub, [Linux is the cheapest option](https://docs.github.com/en/free-pro-team@latest/github/setting-up-and-managing-billing-and-payments-on-github/about-billing-for-github-actions) and should produce results identical to the other OSes. diff --git a/.github/workflows/linux.yaml b/.github/workflows/linux.yaml index 8a05f584..9c9247a8 100644 --- a/.github/workflows/linux.yaml +++ b/.github/workflows/linux.yaml @@ -1,7 +1,7 @@ # This is the name of the workflow, visible on GitHub UI name: linux -on: [pull_request] +on: [push, pull_request] jobs: "unittest_lint_sampleproject": diff --git a/.github/workflows/macos.yaml b/.github/workflows/macos.yaml index ffd88f9d..96357648 100644 --- a/.github/workflows/macos.yaml +++ b/.github/workflows/macos.yaml @@ -1,7 +1,7 @@ # This is the name of the workflow, visible on GitHub UI name: macos -on: [pull_request] +on: [push, pull_request] jobs: "unittest_lint_sampleproject": diff --git a/.github/workflows/windows.yaml b/.github/workflows/windows.yaml index 6001624e..6a4afa72 100644 --- a/.github/workflows/windows.yaml +++ b/.github/workflows/windows.yaml @@ -1,7 +1,7 @@ # This is the name of the workflow, visible on GitHub UI name: windows -on: [pull_request] +on: [push, pull_request] jobs: "unittest_lint_sampleproject": From aed9f3832b26f79b85ea46ebe931d9b13a8a6eb3 Mon Sep 17 00:00:00 2001 From: James Foster Date: Mon, 15 Feb 2021 11:43:26 -0800 Subject: [PATCH 2/2] Add to CHANGELOG.md --- CHANGELOG.md | 1 + 1 file changed, 1 insertion(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 0cac76ad..bd451c6f 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -9,6 +9,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/). ### Added ### Changed +- Run tests on push as well as on a pull request so developers can see impact ### Deprecated