Fix inheritance of overloaded Print / Write functions

Author: ianfixes

CHANGELOG.md

@@ -17,6 +17,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/).
 
 ### Fixed
 - Compile errors / portability issues in `WString.h` and `Print.h`, first reported by `dfrencham` on GitHub
+- Compile errors / inheritance issues in `Print.h` and `Stream.h`, first reported by `dfrencham` on GitHub
 
 ### Security
 

SampleProjects/TestSomething/test/serial.cpp

@@ -43,6 +43,21 @@ unittest(serial_ports)
     assertEqual("bcdefg", state->serialPort[0].dataOut);
   }
 
+  unittest(all_serial_writes)
+  {
+    GodmodeState* state = GODMODE();
+    state->serialPort[0].dataIn = "";
+    state->serialPort[0].dataOut = "";
+
+    char str[4] = "xyz";
+    Serial.write(reinterpret_cast<const uint8_t *>(str ), 3);
+    Serial.print((int)1);
+    Serial.print((long)2);
+    Serial.print((double)3.4);
+    Serial.print((char)'a');
+    Serial.print("b");
+  }
+
 #endif
 
 unittest_main()

cpp/arduino/HardwareSerial.h

@@ -57,11 +57,8 @@ class HardwareSerial : public Stream, public ObservableDataStream
       return 1;
     }
 
-    inline size_t write(unsigned long n) { return write((uint8_t)n); }
-    inline size_t write(long n) { return write((uint8_t)n); }
-    inline size_t write(unsigned int n) { return write((uint8_t)n); }
-    inline size_t write(int n) { return write((uint8_t)n); }
-    // using Print::write; // pull in write(str) and write(buf, size) from Print
+    // https://stackoverflow.com/a/4271276
+    using Print::write; // pull in write(str) and write(buf, size) from Print
     operator bool() { return true; }
 
 };

cpp/arduino/Stream.h

@@ -56,11 +56,11 @@ class Stream : public Print
       return ret;
     }
 
+    // https://stackoverflow.com/a/4271276
     using Print::write;
 
     virtual size_t write(uint8_t aChar) { mGodmodeDataIn->append(String((char)aChar)); return 1; }
 
-
     Stream() {
       mTimeoutMillis = 1000;
       mGodmodeMicrosDelay = NULL;