expose board manager URL settings in ArduinoCmd

Author: ianfixes

CHANGELOG.md

@@ -6,6 +6,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/).
 
 ## [Unreleased]
 ### Added
+- Arduino command wrapper now natively supports board manager URLs
 
 ### Changed
 - Centralized file listing code in `arduino_ci_remote.rb`

exe/arduino_ci_remote.rb

@@ -161,7 +161,7 @@ def display_files(pathname)
 all_urls = all_packages.map { |p| config.package_url(p) }.uniq.reject(&:nil?)
 unless all_urls.empty?
   assure("Setting board manager URLs") do
-    @arduino_cmd.set_pref("boardsmanager.additional.urls", all_urls.join(","))
+    @arduino_cmd.board_manager_urls = all_urls
   end
 end
 

lib/arduino_ci/arduino_cmd.rb

@@ -145,6 +145,21 @@ def run_and_capture(*args, **kwargs)
       ret
     end
 
+    # Board manager URLs
+    # @return [Array<String>] The additional URLs used by the board manager
+    def board_manager_urls
+      url_list = get_pref("boardsmanager.additional.urls")
+      return [] if url_list.nil?
+
+      url_list.split(",")
+    end
+
+    # Set board manager URLs
+    # @return [Array<String>] The additional URLs used by the board manager
+    def board_manager_urls=(all_urls)
+      set_pref("boardsmanager.additional.urls", all_urls.join(","))
+    end
+
     # check whether a board is installed
     # we do this by just selecting a board.
     #   the arduino binary will error if unrecognized and do a successful no-op if it's installed

spec/arduino_cmd_spec.rb

@@ -65,6 +65,23 @@ def get_sketch(dir, file)
     end
   end
 
+
+  context "board_manager" do
+    it "Reads and writes board_manager URLs" do
+      fake_urls = ["http://foo.bar", "http://arduino.ci"]
+      existing_urls = arduino_cmd.board_manager_urls
+
+      # try to ensure maxiumum variability in the test
+      test_url_sets = (existing_urls.empty? ? [fake_urls, []] : [[], fake_urls]) + [existing_urls]
+
+      test_url_sets.each do |urls|
+        arduino_cmd.board_manager_urls = urls
+        expect(arduino_cmd.board_manager_urls).to match_array(urls)
+      end
+    end
+  end
+
+
   context "verify_sketch" do
 
     sketch_path_ino = get_sketch("FakeSketch", "FakeSketch.ino")