-
Notifications
You must be signed in to change notification settings - Fork 3k
KVStore: Fix buffer overrun when device key size doesn't match #12875
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
KVStore: Fix buffer overrun when device key size doesn't match #12875
Conversation
@ccli8, thank you for your changes. |
CI started |
Test run: FAILEDSummary: 1 of 6 test jobs failed Failed test jobs:
|
There are lot of failed related test, please review |
4901f11
to
f01773a
Compare
This PR adds check for device key size and will catch key size mismatch cases, which are missed before. #12823 can have similar issues. To address them, I make the modifications:
|
Pull request has been modified.
This change fixes buffer overrun when injected device key is 32-byte but read as 16-byte.
f01773a
to
405ee47
Compare
Do rebase to base on #12823 |
Test run: SUCCESSSummary: 6 of 6 test jobs passed |
Will be merged as soon as we have 6.0.0 beta1 released |
Summary of changes
This PR tries to fix #12822, where buffer may overrun when injected device key is 32-byte but read as 16-byte.
Pull request type
Test results