SFDP: fixes a trace print

Veijo Pesonen · Veijo Pesonen · commit eb01afb1983f · 2020-03-17T17:48:39.000+02:00
Indexing runs from highest to lowest, not other way round.
diff --git a/drivers/source/SFDP.cpp b/drivers/source/SFDP.cpp
@@ -398,8 +398,9 @@ int sfdp_iterate_next_largest_erase_type(uint8_t &bitfield,
                                          const sfdp_smptbl_info &smptbl)
 {
     uint8_t type_mask = SFDP_ERASE_BITMASK_TYPE4;
-    int i_ind = 0;
     int largest_erase_type = 0;
+
+    int i_ind;
     for (i_ind = 3; i_ind >= 0; i_ind--) {
         if (bitfield & type_mask) {
             largest_erase_type = i_ind;
@@ -414,7 +415,7 @@ int sfdp_iterate_next_largest_erase_type(uint8_t &bitfield,
         type_mask = type_mask >> 1;
     }
 
-    if (i_ind == 4) {
+    if (i_ind == -1) {
         tr_error("No erase type was found for current region addr");
     }
     return largest_erase_type;

Original file line number	Diff line number	Diff line change
`@@ -398,8 +398,9 @@ int sfdp_iterate_next_largest_erase_type(uint8_t &bitfield,`
`398`	`398`	`const sfdp_smptbl_info &smptbl)`
`399`	`399`	`{`
`400`	`400`	`uint8_t type_mask = SFDP_ERASE_BITMASK_TYPE4;`
`401`		`- int i_ind = 0;`
`402`	`401`	`int largest_erase_type = 0;`
	`402`	`+`
	`403`	`+ int i_ind;`
`403`	`404`	`for (i_ind = 3; i_ind >= 0; i_ind--) {`
`404`	`405`	`if (bitfield & type_mask) {`
`405`	`406`	`largest_erase_type = i_ind;`
`@@ -414,7 +415,7 @@ int sfdp_iterate_next_largest_erase_type(uint8_t &bitfield,`
`414`	`415`	`type_mask = type_mask >> 1;`
`415`	`416`	`}`
`416`	`417`
`417`		`- if (i_ind == 4) {`
	`418`	`+ if (i_ind == -1) {`
`418`	`419`	`tr_error("No erase type was found for current region addr");`
`419`	`420`	`}`
`420`	`421`	`return largest_erase_type;`