pass spans by value

paul-szczepanek-arm · paul-szczepanek-arm · commit af0e32b0edb0 · 2020-09-07T14:42:25.000+01:00
diff --git a/platform/include/platform/CircularBuffer.h b/platform/include/platform/CircularBuffer.h
@@ -162,7 +162,7 @@ class CircularBuffer {
      *
      * @param src Data to be pushed to the buffer.
      */
-    void push(const mbed::Span<const T>& src)
+    void push(mbed::Span<const T> src)
     {
         push(src.data(), src.size());
     }
@@ -245,7 +245,7 @@ class CircularBuffer {
      *
      * @return The span with the size set to number of elements popped using the buffer passed in as the parameter.
      */
-    mbed::Span<T> pop(const mbed::Span<T>& dest)
+    mbed::Span<T> pop(mbed::Span<T> dest)
     {
         CounterType popped = pop(dest.data(), dest.size());
         return mbed::make_Span(dest.data(), popped);

Original file line number	Diff line number	Diff line change
`@@ -162,7 +162,7 @@ class CircularBuffer {`
`162`	`162`	`*`
`163`	`163`	`* @param src Data to be pushed to the buffer.`
`164`	`164`	`*/`
`165`		`- void push(const mbed::Span<const T>& src)`
	`165`	`+ void push(mbed::Span<const T> src)`
`166`	`166`	`{`
`167`	`167`	`push(src.data(), src.size());`
`168`	`168`	`}`
`@@ -245,7 +245,7 @@ class CircularBuffer {`
`245`	`245`	`*`
`246`	`246`	`* @return The span with the size set to number of elements popped using the buffer passed in as the parameter.`
`247`	`247`	`*/`
`248`		`- mbed::Span<T> pop(const mbed::Span<T>& dest)`
	`248`	`+ mbed::Span<T> pop(mbed::Span<T> dest)`
`249`	`249`	`{`
`250`	`250`	`CounterType popped = pop(dest.data(), dest.size());`
`251`	`251`	`return mbed::make_Span(dest.data(), popped);`