Skip to content

Commit 36468c9

Browse files
authored
Merge pull request #2281 from geky/tools-ca-set-arith-fix
[tools] Fix precedence issue in cumulative attribute set-arithmetic
2 parents 4d8cbdc + 63f9b03 commit 36468c9

File tree

4 files changed

+29
-1
lines changed

4 files changed

+29
-1
lines changed

tools/config.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -169,7 +169,8 @@ def strict_cumulative_overrides(self, overrides):
169169

170170
def update_target(self, target):
171171
setattr(target, self.name, list(
172-
set(getattr(target, self.name, [])) | self.additions - self.removals))
172+
(set(getattr(target, self.name, [])) | self.additions) - self.removals))
173+
173174

174175

175176
# 'Config' implements the mbed configuration mechanism
Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,8 @@
1+
{
2+
"name": "lib1",
3+
"target_overrides": {
4+
"*": {
5+
"target.features_remove": ["IPV4"]
6+
}
7+
}
8+
}
Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,11 @@
1+
{
2+
"custom_targets": {
3+
"test_target": {
4+
"core": "Cortex-M0",
5+
"extra_labels": [],
6+
"features": ["IPV4"],
7+
"default_build": "standard"
8+
}
9+
}
10+
}
11+
Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,8 @@
1+
# Testing when adding two features
2+
3+
expected_results = {
4+
"test_target": {
5+
"desc": "test removing features",
6+
"expected_features": []
7+
}
8+
}

0 commit comments

Comments
 (0)