Skip to content

Commit 3387a32

Browse files
fixup! [USB] Clean up USB id and string assignment
1 parent a0badeb commit 3387a32

File tree

1 file changed

+15
-12
lines changed

1 file changed

+15
-12
lines changed

cores/arduino/stm32/usb/usbd_desc.c

Lines changed: 15 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -30,16 +30,19 @@
3030
* specified, default to the ST VID, with a PID assigned to HID or a PID
3131
* assigned to CDC devices. */
3232
#if !USBD_PID && !USBD_VID
33+
// Undef the default zero values
34+
#undef USBD_PID
35+
#undef USBD_VID
36+
// Define default values, based on the USB class used
3337
#define USBD_VID 0x0483
34-
#ifdef USBD_USE_HID_COMPOSITE
38+
#if defined(USBD_USE_HID_COMPOSITE)
3539
#define USBD_PID 0x5711
36-
#endif
37-
#ifdef USBD_USE_CDC
40+
#elif defined(USBD_USE_CDC)
3841
#define USBD_PID 0x5740
3942
#endif
4043
#endif /* !USBD_PID && !USBD_VID */
4144

42-
#if !USBD_PID || !USBD_PID
45+
#if !USBD_VID || !USBD_PID
4346
#error "USB VID or PID not specified"
4447
#endif
4548

@@ -76,17 +79,17 @@
7679
#endif
7780

7881
#ifdef USBD_USE_HID_COMPOSITE
79-
#define USBD_CLASS_CONFIGURATION_HS_STRING CONCATS(USB_PRODUCT, "HID Config")
80-
#define USBD_CLASS_INTERFACE_HS_STRING CONCATS(USB_PRODUCT, "HID Interface")
81-
#define USBD_CLASS_CONFIGURATION_FS_STRING CONCATS(USB_PRODUCT, "HID Config")
82-
#define USBD_CLASS_INTERFACE_FS_STRING CONCATS(USB_PRODUCT, "HID Interface")
82+
#define USBD_CLASS_CONFIGURATION_HS_STRING CONCATS(BOARD_NAME, "HID Config")
83+
#define USBD_CLASS_INTERFACE_HS_STRING CONCATS(BOARD_NAME, "HID Interface")
84+
#define USBD_CLASS_CONFIGURATION_FS_STRING CONCATS(BOARD_NAME, "HID Config")
85+
#define USBD_CLASS_INTERFACE_FS_STRING CONCATS(BOARD_NAME, "HID Interface")
8386
#endif /* USBD_USE_HID_COMPOSITE */
8487

8588
#ifdef USBD_USE_CDC
86-
#define USBD_CLASS_CONFIGURATION_HS_STRING CONCATS(USB_PRODUCT, "CDC Config")
87-
#define USBD_CLASS_INTERFACE_HS_STRING CONCATS(USB_PRODUCT, "CDC Interface")
88-
#define USBD_CLASS_CONFIGURATION_FS_STRING CONCATS(USB_PRODUCT, "CDC Config")
89-
#define USBD_CLASS_INTERFACE_FS_STRING CONCATS(USB_PRODUCT, "CDC Interface")
89+
#define USBD_CLASS_CONFIGURATION_HS_STRING CONCATS(BOARD_NAME, "CDC Config")
90+
#define USBD_CLASS_INTERFACE_HS_STRING CONCATS(BOARD_NAME, "CDC Interface")
91+
#define USBD_CLASS_CONFIGURATION_FS_STRING CONCATS(BOARD_NAME, "CDC Config")
92+
#define USBD_CLASS_INTERFACE_FS_STRING CONCATS(BOARD_NAME, "CDC Interface")
9093
#endif /* USBD_USE_CDC */
9194

9295
/* Private macro -------------------------------------------------------------*/

0 commit comments

Comments
 (0)